Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite copy #502

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Rewrite copy #502

merged 1 commit into from
Oct 27, 2017

Conversation

manidlou
Copy link
Collaborator

@manidlou manidlou commented Oct 19, 2017

Started #374.

Fixes #83 and #198.

This implementation uses recursive pattern for copying directories. recursive pattern has shown better performance than Promise (copy-benchmark). If this looks good, then we will apply fs.copyFile() to it.

Any feedback appreciated! 😄

@manidlou
Copy link
Collaborator Author

Aah! I forgot node 4 cannot read new es {} module loading syntax!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 87.576% when pulling d9d0e74 on rewrite-copy into 2599b67 on master.

Repository owner deleted a comment from coveralls Oct 19, 2017
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Briefly reviewed tests; your test descriptions look like you're testing all the right cases. Did not line-by-line review all the actual test code to ensure the tests actually assert the behavior described.

Would like at least quick review from @jprichardson as well.

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 19, 2017

@manidlou Not sure why this is WIP? We should probably merge this into a develop branch and have a separate PR for fs.copyFile changes.

@manidlou
Copy link
Collaborator Author

@manidlou Not sure why this is WIP?

Yeah, primarily because of fs.copyFile.

We should probably merge this into a develop branch and have a separate PR for fs.copyFile changes.

Good idea! 👍

@manidlou manidlou changed the title [WIP] Rewrite copy Rewrite copy Oct 19, 2017
@jprichardson
Copy link
Owner

Stellar work @manidlou! Please squash the changes to account for the destructuring fix, and then it LGTM.

@manidlou
Copy link
Collaborator Author

Please squash the changes to account for the destructuring fix, and then it LGTM.

Sure thing.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 87.576% when pulling fe0bfe2 on rewrite-copy into 2599b67 on master.

@manidlou
Copy link
Collaborator Author

Squash done! 😃

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 20, 2017

Will merge when I’m on desktop.

@manidlou
Copy link
Collaborator Author

@RyanZim ping?!

@RyanZim RyanZim changed the base branch from master to develop October 27, 2017 12:33
@RyanZim RyanZim merged commit 166f4a7 into develop Oct 27, 2017
@RyanZim
Copy link
Collaborator

RyanZim commented Oct 27, 2017

Thanks for the ping @manidlou, I totally forgot this. Merged to new develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants