feat: add support for REPOSITORIES regex with app installation tokens #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible 'pageSize' works as intended, potentially due to some kind of hard to find legacy support or overlap with octokit.net (where the parameter name is explicitly that), but the correct name of this parameter in the REST API is 'per_page'. It appears likely that 'pageSize' has had no effect whatsoever. The actual action code defaults the value to '30' which happens to align with the REST API's default for when 'per_page' is not provided. While the tests do use an explicit value (namely '3'), the Jest nock for each endpoint dictate the number of results there instead of the actual parameter value.
oblivioncth
force-pushed
the
install_regex
branch
from
6e087a6
to
e937e82
Compare
oblivioncth
changed the title
jpoehnelt
approved these changes
Sep 26, 2024
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can squash if desired.
The tests, including the new one I've added, all pass and I've tested the new functionality on one of my own repositories.
I don't use JS/TS normally, but did the best I could. Of course let me know if you want any of this handled differently