Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Idea for interface #104

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

jcbhmr
Copy link

@jcbhmr jcbhmr commented Jul 16, 2023

This is a pretty basic action that would appear to do most(?) of what this action already does. THIS PR IS NOT INTENDED TO MERGE it's just a way to "show off" what I'm doing/thinking. 😊

Highlights:

Still needs:

  • Variables!
  • Input and feedback on interface ideas. i.e. should it be "mode" or "set-secret:" and "delete-secret" as an input or something else [Discussion] Ideas for v2 #103
  • clarification on whether or not any of this stuff that I'm doing is ever likely to get merged or what ❤️
  • testing around if an environment does not exist, the action fails #65
  • actual "real" tests instead of just dry-run everything (.e. a real repo/token + manual validation that it works)

@jcbhmr
Copy link
Author

jcbhmr commented Jul 17, 2023

btw yes i could switch to ousing octokit instead of the gh cli, it's just that the gh cli was a bit easier for me to get working quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant