Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.9.0 changelog. Fixes #949 #967

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

benvdh
Copy link
Contributor

@benvdh benvdh commented Jul 29, 2024

This PR:

I noticed PR #910 apart from adding support for Python 3.12, also drops support for python 3.7 which might be considered as a backwards incompatible change. So not sure if you want to go 3.0 for that (instead of 2.9.0), or since none of of our own APIs break we stick with 2.9.0.

@jpadilla or @auvipy It would be great if you could review and release the next version of PyJWT...

Fixes #949.

@benvdh benvdh changed the title Add 2.9.0 changelog. Fixes #949. Add 2.9.0 changelog. Fixes #949 Jul 29, 2024
@benvdh
Copy link
Contributor Author

benvdh commented Jul 30, 2024

@jpadilla There are now 2 approving reviews, and thereby this PR meets all requirements to get merged. When do you expect this can be merged and released?

If there's anything else I can do, just let me know. I'd love to help to get this done.

Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benvdh thank you very much! I'll get a release going today.

@jpadilla jpadilla merged commit 868cf4a into jpadilla:master Jul 31, 2024
24 checks passed
@benvdh benvdh deleted the add-2.9.0-changelog branch July 31, 2024 22:12
@benvdh-incentro
Copy link

@benvdh thank you very much! I'll get a release going today.

@jpadilla Thx! For the review and merge. Can you approve the flow here, and add the release?

https://github.com/jpadilla/pyjwt/actions/runs/10180388114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a release 2.9.0? Or create a checklist that contributors can help with?
5 participants