-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling 'ImmatureSignatureError' for issued_at time #794
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Sep 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase
ci triggerred |
auvipy
approved these changes
Oct 15, 2022
there is a bug report #814 , can you verify? |
Replied there. |
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling 'ImmatureSignatureError' for issued_at time when it is a future time epoch.
When the
issued_at
time in the payload is greater than thecurrent time + leeway
then we can call it out asImmatureSignatureError
as we do for(nbf)
We have
nbf
in the payload but still, with propernbf
someone can call the API with improperiat
to fool the system.Example:
Here the token is valid from 14:48(as per
nbf
) and has an expiry range of 5min fromiat
which makes the token valid. But theiat
is less thannbf
which makes the token valid for 7mins instead of 5min. This should not happen as per contract but attackers may do something like this even makingiat
andexp
with the year 2023 which still makes the token valid.We can restrict the same way as we do for
nbf
.