-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for compressed payloads #753
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Is this something we can instead provide some kind of hook for? This seems kinda specific use case that I’d think would better live outside this lib |
@auvipy let's revert this please. I'd like to think it through a bit more. Sorry for the last minute comments. |
I am going to revert this for now, but supporting compressed payload may be a future endeaviour |
It's strange that this was merged when #666 is pending to do the same thing. |
@jpadilla Gan you give some update if there is already a way for some sort of callback that can be passed to do this? |
A bunch of US states are using Smart Health Cards (https://smarthealth.cards/en/) to issue digital proof of COVID-19 vaccination. The QR code on the certificate decodes to a JWT token, but it has a compressed payload and upstream PyJWT didn't handle it. So I offer this contribution.
This patch introduces a dependency on
zlib
but as an old, salty python developer who hasn't lifted myself out of the requirements.txt era, I haven't figured out how this project is managing dependencies. Can you help me understand what needs to be done?