Move setup information to declarative setup.cfg #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a declarative syntax to avoid mixing code and configuration. Simplifies handling of long description and version by reducing some boilerplate. For details on this setuptools feature, see: https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files
auvipy
approved these changes
Jun 11, 2020
jpadilla
reviewed
Jun 15, 2020
| tests = | ||
| pytest>=4.0.1,<5.0.0 | ||
| pytest-cov>=2.6.0,<3.0.0 | ||
|
|
There was a problem hiding this comment.
@jdufresne is it possible to do something like this using this setup?
EXTRAS_REQUIRE["dev"] = (
EXTRAS_REQUIRE["tests"]
+ EXTRAS_REQUIRE["cryptography"]
+ EXTRAS_REQUIRE["jwks-client"]
+ ["mypy", "pre-commit"]
)
There was a problem hiding this comment.
As far as I know, values can't be added in setup.cfg like in Python code, but we could add a dev extras and just copy the entries manually.
jpadilla
pushed a commit
that referenced
this pull request
Jun 19, 2020
Use a declarative syntax to avoid mixing code and configuration. Simplifies handling of long description and version by reducing some boilerplate. For details on this setuptools feature, see: https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a declarative syntax to avoid mixing code and configuration.
Simplifies handling of long description and version by reducing some
boilerplate.
For details on this setuptools feature, see:
https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files