Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warnings about user code, not pyjwt code #494

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

mgedmin
Copy link
Contributor

@mgedmin mgedmin commented Jun 9, 2020

This assumes all direct calls to private methods (leading underscore in name) are from pyjwt code, hence stacklevel=3 nor 2.

This assumes all direct calls to private methods (leading underscore in name)
are from pyjwt code, hence stacklevel=3 nor 2.
@coveralls
Copy link

coveralls commented Jun 9, 2020

Pull Request Test Coverage Report for Build 217

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 216: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@auvipy auvipy merged commit 079849d into jpadilla:master Jun 9, 2020
@mgedmin mgedmin deleted the warning-stack-level branch June 11, 2020 13:30
jpadilla pushed a commit that referenced this pull request Jun 19, 2020
This assumes all direct calls to private methods (leading underscore in name)
are from pyjwt code, hence stacklevel=3 nor 2.
@jpadilla jpadilla added this to the v2.0.0 milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants