Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 406 #454

Merged
merged 5 commits into from
Nov 16, 2019
Merged

Fix 406 #454

merged 5 commits into from
Nov 16, 2019

Conversation

justinbaur
Copy link
Contributor

Fixes GH-406 (#406)

I played around with different ideas on how to implement the passing of the header map but wanted to stick with something native without lots of extra parsing.

Let me know what you think.

@coveralls
Copy link

coveralls commented Oct 25, 2019

Pull Request Test Coverage Report for Build 97

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 94: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@jpadilla jpadilla merged commit e875db1 into jpadilla:master Nov 16, 2019
@justinbaur justinbaur deleted the fix-406 branch November 22, 2019 01:07
@jpadilla jpadilla added this to the v2.0.0 milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode via command line cannot set headers
3 participants