Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.py test command in favor of pytest and tox #442

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Remove setup.py test command in favor of pytest and tox #442

merged 1 commit into from
Oct 6, 2019

Conversation

jdufresne
Copy link
Contributor

Using pytest and tox directly is simpler and more conventional then
going through setup.py. Using setup.py installs packages as eggs where
as tox uses the more typical pip.

Overall simplifies setup.py.

Fixes #415

Using pytest and tox directly is simpler and more conventional then
going through setup.py. Using setup.py installs packages as eggs where
as tox uses the more typical pip.

Overall simplifies setup.py.

Fixes #415
@coveralls
Copy link

coveralls commented Sep 28, 2019

Pull Request Test Coverage Report for Build 76

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.565%

Totals Coverage Status
Change from base Build 75: 0.0%
Covered Lines: 2143
Relevant Lines: 2874

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 28, 2019

Pull Request Test Coverage Report for Build 76

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.84%

Totals Coverage Status
Change from base Build 75: -0.7%
Covered Lines: 1592
Relevant Lines: 2156

💛 - Coveralls

@jpadilla
Copy link
Owner

jpadilla commented Oct 6, 2019

Perfect, thanks! 🎆

@jpadilla jpadilla merged commit 3a20892 into jpadilla:master Oct 6, 2019
@jdufresne jdufresne deleted the setup branch October 7, 2019 01:32
@jpadilla jpadilla added this to the v2.0.0 milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 fails after running tests
3 participants