This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
[ISSUE #2554] Throw if start type is not number #2567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks AJ. Can you add one or two tests and use the commit template from https://github.com/joyent/node/wiki/Contributing? |
| @@ -1038,8 +1038,13 @@ var ReadStream = fs.ReadStream = function(path, options) { | |||
| if (this.encoding) this.setEncoding(this.encoding); | |||
|
|
|||
| if (this.start !== undefined) { | |||
There was a problem hiding this comment.
should be able to kill this conditional now
There was a problem hiding this comment.
not quite. this.start is allowed to be undefined
|
@coolaj86: Are you going to update the PR? If not, can you close it? |
coolaj86
pushed a commit
to coolaj86/node
that referenced
this pull request
Feb 18, 2012
This was referenced Feb 18, 2012
isaacs
pushed a commit
that referenced
this pull request
Feb 27, 2012
isaacs
pushed a commit
that referenced
this pull request
Feb 27, 2012
isaacs
added a commit
to isaacs/node-v0.x-archive
that referenced
this pull request
Mar 2, 2012
* Upgrade V8 to 3.6.6.24 * dtrace ustack helper improvements (Dave Pacheco) * API Documentation refactor (isaacs) * nodejs#2827 net: fix race write() before and after connect() (koichik) * nodejs#2554 nodejs#2567 throw if fs args for 'start' or 'end' are strings (AJ ONeal) * punycode: Update to v1.0.0 (Mathias Bynens) * Make a fat binary for the OS X pkg (isaacs) * Fix hang on accessing process.stdin (isaacs) * repl: make tab completion work on non-objects (Nathan Rajlich) * Fix fs.watch on OS X (Ben Noordhuis) * Fix nodejs#2515 nested setTimeouts cause premature process exit (Ben Noordhuis) * windows: fix time conversion in stat (Igor Zinkovsky) * windows: fs: handle EOF in read (Brandon Philips) * windows: avoid IOCP short-circuit on non-ifs lsps (Igor Zinkovsky) * Upgrade npm to 1.1.4 (isaacs) - windows fixes - Bundle nested bundleDependencies properly - install: support --save with url install targets - shrinkwrap: behave properly with url-installed modules - support installing uncompressed tars or single file modules from urls etc. - don't run make clean on rebuild - support HTTPS-over-HTTP proxy tunneling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.createReadStream allows strings to be passed as
startandend, but then concatenates them rather than throwing an error or converting them.see Issue #2554