Skip to content

Commit

Permalink
test: do not check TXT content in test-dns-any
Browse files Browse the repository at this point in the history
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.

PR-URL: nodejs#18547
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
joyeecheung committed Mar 30, 2018
1 parent 9fb711a commit f969be6
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions test/internet/test-dns-any.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ const checkers = {
checkTXT(r) {
assert.ok(Array.isArray(r.entries));
assert.ok(r.entries.length > 0);
r.entries.forEach((txt) => {
assert(txt.startsWith('v=spf1'));
});
assert.strictEqual(r.type, 'TXT');
},
checkSOA(r) {
Expand Down

0 comments on commit f969be6

Please sign in to comment.