-
Notifications
You must be signed in to change notification settings - Fork 10
Update for Webpack 4 #24
base: master
Are you sure you want to change the base?
Conversation
@ruszki: Thank you very much for the PR 🥇 I'm sorry I haven't replied until now; I apologise. I've been testing your updates, and the following bits I've verified works:
However, for me the actual
script.src = __webpack_require__.p + "" + ({}[chunkId]||chunkId) + "." + {"0":"26127e76b37f4c6b009a","1":"219d2ef64bc371d00ed4","2":"df49e3b2b0df799fb05c","3":"5e62fd0175a2093fa673"}[chunkId] + ".dev.js";
script.src = __webpack_require__.p + window["webpackManifest"][chunkId]; However, the contents of <script type="text/javascript">window.webpackManifest={}</script> As I currently have quite little time to work on the plugin, I truly appreciate you taking the time to do the necessary updates to get the plugin to work with webpack@4 and html-webpack-plugin@3.2.0. If you have time to look at these last bits as well, it'd be super! Thanks again for the effort! ⭐️ |
@jouni-kantola Hello, is there a plan to wrap this up anytime soon? I see you are close to solving it :) |
How's it going with this one? :) Waiting eagerly too! |
@jouni-kantola |
What's up here @jouni-kantola? Any updates? |
no updates? |
I'll reiterate the comment I made in the issue for reaching webpack 4 here as well: |
As stated above in this PR (#24 (comment)), I couldn't get I'll gladly take on more maintainers working on this plugin, and moving this update into goal would be a first good step. |
@whizkydee: We can continue the discussion here. It'd be awesome if you want to continue maintaining |
Alright. Great! I'll just check the repo now and look into the code later in the day. |
I would like to add that we successfully use this version with the following config of optimization field for Webpack version ~4.1.1. It works probably because runtimeChunk is enabled. At least, that's how I remember. {
splitChunks: {
maxAsyncRequests: 3,
cacheGroups: {
default: {
minChunks: 2,
priority: -20,
reuseExistingChunk: true
},
vendors: {
test: /[\\/]node_modules[\\/]/,
name: "components",
chunks: "all",
priority: -10
}
}
},
runtimeChunk: {
name: "bootstrap"
},
removeAvailableModules: false,
removeEmptyChunks: false
} |
@ruszki: Thank you for the input. That is really helpful! As a chunk manifest exists by default, I'd expect As followup testing, using the suggested config described for
I think there are more cases that need to be covered before merging the PR. |
Webpack 5 is about to be released :) still no Webpack 4 support |
Resolves #23