Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine axTicksByTime and axTicksByTime2 #74

Closed
joshuaulrich opened this issue Apr 11, 2015 · 1 comment
Closed

Combine axTicksByTime and axTicksByTime2 #74

joshuaulrich opened this issue Apr 11, 2015 · 1 comment
Labels
enhancement Enhancement to existing feature plot
Projects
plot.xts() improvements
Milestone
Release 0.11-0

Comments

@joshuaulrich
Copy link
Owner

xts exports axTicksByTime, but the new plot.xts uses axTicksByTime2 that came from the port of chart_Series to plot.xts. For simplicity's sake, these two functions should be combined... once we understand their differences.

We need to ensure not to break anything that currently uses axTicksByTime (e.g. many of the charting functions in PerformanceAnalytics).
@joshuaulrich joshuaulrich added the enhancement Enhancement to existing feature label Apr 11, 2015
@joshuaulrich joshuaulrich added plot and removed plot labels Jul 30, 2017
@rossb34 rossb34 mentioned this issue Jun 11, 2018
Closed
@joshuaulrich
Copy link
Owner Author

joshuaulrich commented Jun 11, 2018 •
edited
Loading

Consider how graphics::axis.POSIXct() determines points and labels. periodicity() might be useful here, since it does something similar and provides the start, end, and frequency of the series.

joshuaulrich pushed a commit that referenced this issue Jun 12, 2018
@joshuaulrich
Combine axTicksByTime2() and axTicksByTime()
a5d2d2e 
axTicksByTime() has long been exported from xts, so its behavior is
maintained as closely as possible. axTicksByTime2() came from the port
of quantmod::chart_Series() to plot.xts().

Add millisecond and microsecond tick.opts, both with tick.k.opts of 1.
Also avoid calls to strsplit() to get the arguments for the endpoints()
call, and when calculating 'cl' and 'ck'. Move tick.k.opts definition
closer to its use. Make sure 'lt' is less than or equal to the number
of observations.

Fixes #74.
joshuaulrich added a commit that referenced this issue Jun 12, 2018
@joshuaulrich
Combine axTicksByTime2() and axTicksByTime()
e55685b 
axTicksByTime() has long been exported from xts, so its behavior is
maintained as closely as possible. axTicksByTime2() came from the port
of quantmod::chart_Series() to plot.xts().

Add millisecond and microsecond tick.opts, both with tick.k.opts of 1.
Also avoid calls to strsplit() to get the arguments for the endpoints()
call, and when calculating 'cl' and 'ck'. Move tick.k.opts definition
closer to its use. Make sure 'lt' is less than or equal to the number
of observations.

Fixes #74.
@joshuaulrich joshuaulrich added this to the Release 0.11-0 milestone Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement to existing feature plot
Projects
plot.xts() improvements
Refactor
Milestone
Release 0.11-0
Development

No branches or pull requests
1 participant
@joshuaulrich