subset column with numeric value 0 <= j < 1 causes segfault #413

joshuaulrich · 2024-01-31T22:56:35Z

Yes this is silly, but it shouldn't crash the R session.

require(xts)
data(sample_matrix)
x <- as.xts(sample_matrix)
x[, 0.1]

Convert 'i' to integer in the R code to avoid issues when it's passed to the C code. I couldn't get this to crash like I could with the code for 'j', but it caused incorrect results when values in 'i' were set to zero during conversion to integer. See #413.

We need to convert 'i' and 'j' to integer if they're numeric with a fractional component. This was only being done when 'i' and 'j' were positive. Also fix the if-statement. sum() could have returned NA and it's better to use isTRUE() and any() anyway. Fixes #415. See #413.

joshuaulrich added the bug label Jan 31, 2024

joshuaulrich self-assigned this Jan 31, 2024

joshuaulrich mentioned this issue Feb 6, 2024

subset with negative non-integer 'i' or 'j' does not warn #415

Closed

joshuaulrich closed this as completed in c0dec34 Feb 6, 2024

joshuaulrich added this to the Next release milestone Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

subset column with numeric value 0 <= j < 1 causes segfault #413

subset column with numeric value 0 <= j < 1 causes segfault #413

joshuaulrich commented Jan 31, 2024

subset column with numeric value 0 <= j < 1 causes segfault #413

subset column with numeric value 0 <= j < 1 causes segfault #413

Comments

joshuaulrich commented Jan 31, 2024