CRAN submit for patch issue #3

joshualerickson · Apr 1, 2023 · 29684b5 · 29684b5
1 parent f894f3e
commit 29684b5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: whitewater
 Title: Parallel Processing Options for Package 'dataRetrieval'
-Version: 0.1.2
+Version: 0.1.3
 Authors@R: 
     person(given = "Josh",
            family = "Erickson",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# whitewater 0.1.3  
+
+* patch with functions that use `dplyr::slice()`.
+
 # whitewater 0.1.1.9000
 
 * Added a `NEWS.md` file to track changes to the package.  

diff --git a/cran-comments.md b/cran-comments.md
@@ -5,18 +5,3 @@ There were no ERRORs , NOTEs or WARNINGs.
 ## Downstream dependencies  
 
 There are currently no downstream dependencies for this package.  
-
-## Notes  
-
-**1. (problem)** " \\dontrun{} should only be used if the example really cannot be executed
-(e.g. because of missing additional software, missing API keys, ...) by
-the user. That's why wrapping examples in \\dontrun{} adds the comment
-("# Not run:") as a warning for the user. Does not seem necessary.
-Please replace \\dontrun with \\donttest.
-All your examples are wrapped in \\dontrun{} and therefore do not get tested.
-Please unwrap the examples if that is feasible and if they can be
-executed in < 5 sec for each Rd file or create additionally small toy
-examples to allow automatic testing.
-Please put functions which download data in \\donttest{}."
-
-**1. (response)** The package relies on an API, which requires a connection to the internet. In addition, the `@examples` use parallel processing in some cases. For this reason I think `\dontrun{}` is the best option for `@examples` with API calls and parallel processing examples.