(env) add Ensure module for argument validation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice. |
glennj
reviewed
Sep 22, 2021
src/module/enforce.wren
Outdated
Comment on lines
1
to
11
| class Error { | ||
| toString { message } | ||
| raise() { Fiber.abort(this) } | ||
| } | ||
|
|
||
| class ArgumentError is Error { | ||
| construct new(message) { | ||
| _message = message | ||
| } | ||
| message { _message } | ||
| } |
There was a problem hiding this comment.
This kind of exception hierarchy is clearly something we want in Wren. It could be moved to its own module.
import "errors" for ArgumentErrorWhich will make it easy to extend
import "errors" for Error
class MyError {
construct new() {}
message { "My errors have a constant error message." }
}
```There was a problem hiding this comment.
That's where I'm headed, one thing at a time. :-)
joshgoebel
changed the title
This was referenced Sep 22, 2021
|
Super cool 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.