Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible circular deadlocks #12

Merged
merged 5 commits into from
Aug 13, 2023
Merged

Fix possible circular deadlocks #12

merged 5 commits into from
Aug 13, 2023

Conversation

josehu07
Copy link
Owner

  • Rename GenericClient trait to GenericEndpoint
  • Use try_write() in client send_req() API to avoid blocking-on-send deadlock (due to TCP buffer being full)
  • Make all internal mpsc channels unbounded to avoid channel blocking-on-send deadlocks

@josehu07 josehu07 merged commit fb036a6 into main Aug 13, 2023
4 checks passed
josehu07 added a commit that referenced this pull request Apr 29, 2024
Code structure improvements & benchmarking setups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant