Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate controllers from WebFlux to Web #35

Closed
josdem opened this issue Mar 15, 2024 · 5 comments
Closed

Migrate controllers from WebFlux to Web #35

josdem opened this issue Mar 15, 2024 · 5 comments
Assignees
Labels
development enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@josdem
Copy link
Owner

josdem commented Mar 15, 2024

As developer, I want to migrate controllers from WebFlux to Web so that I can only use Spring Boot web features.

Acceptance Criteria

  • I do not see any Mono or Flux subscription endpoints
  • I do not have WebFlux components in controllers
@josdem josdem added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers development labels Mar 15, 2024
@josdem josdem added this to the Migrate to Spring Web milestone Mar 15, 2024
@kirillsinyuk
Copy link
Collaborator

Good day. You can assign this one on me

@josdem
Copy link
Owner Author

josdem commented Mar 15, 2024

Hey, @kirillsinyuk; nice to see you again and collaborate on a project. Sure, I appreciate your help!

kirillsinyuk added a commit to kirillsinyuk/jugoterapia-webflux that referenced this issue Mar 15, 2024
@kirillsinyuk
Copy link
Collaborator

btw, I have a couple of questions about this task:

  1. what response is expected from the getBeverage handler if no result is found? Usually, there should be 404, but in this case, it might be a breach of contract.
  2. there are some things that still have webflux mention. like packaging or some references in README.md. Just a reminder, in case you wanna change that.

@josdem
Copy link
Owner Author

josdem commented Mar 16, 2024

btw, I have a couple of questions about this task:

  1. what response is expected from the getBeverage handler if no result is found? Usually, there should be 404, but in this case, it might be a breach of contract.
  2. there are some things that still have webflux mention. like packaging or some references in README.md. Just a reminder, in case you wanna change that.

Hi @kirillsinyuk here are my answers:

  1. You are right; there is a miss in the design; it should return 404 when a beverage is not found. I created an issue to cover this missing functionality: Add error handler in controllers #42
  2. Definitely, we should update README.md accordingly, also I want to change the repository name, since we will not use Webflux in controllers.

kirillsinyuk added a commit to kirillsinyuk/jugoterapia-webflux that referenced this issue Mar 16, 2024
kirillsinyuk added a commit to kirillsinyuk/jugoterapia-webflux that referenced this issue Mar 16, 2024
josdem added a commit that referenced this issue Mar 16, 2024
@josdem
Copy link
Owner Author

josdem commented Mar 16, 2024

All tests passing:
35

@josdem josdem closed this as completed Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants