This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
feat: Add nested_column_iter_to_arrays to deserialize inner columns
#1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
=======================================
Coverage 83.39% 83.40%
=======================================
Files 391 391
Lines 42993 43008 +15
=======================================
+ Hits 35853 35869 +16
+ Misses 7140 7139 -1
☔ View full report in Codecov by Sentry. |
sundy-li
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly deserializing an internal column of a struct type requires a
Vec<InitNested>, otherwise the result will not be read correctly.