Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix nested extension types #1334

Merged

Conversation

jondo2010
Copy link
Contributor

This PR fixes various issues with Extension types at various nesting levels. Rebased onto main.

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 83.12% // Head: 83.12% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c1e0f4b) compared to base (e698d48).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head c1e0f4b differs from pull request most recent head b4e1de3. Consider uploading reports for the commit b4e1de3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1334   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files         370      370           
  Lines       40196    40170   -26     
=======================================
- Hits        33414    33393   -21     
+ Misses       6782     6777    -5     
Impacted Files Coverage Δ
src/array/list/mod.rs 83.66% <100.00%> (ø)
src/array/struct_/mod.rs 64.73% <100.00%> (+4.62%) ⬆️
src/array/union/mod.rs 76.55% <100.00%> (-8.07%) ⬇️
src/io/ipc/read/stream_async.rs 74.65% <0.00%> (-2.06%) ⬇️
src/io/json_integration/read/array.rs 85.71% <0.00%> (-0.04%) ⬇️
src/io/ipc/read/file.rs 96.87% <0.00%> (ø)
src/array/union/iterator.rs 61.90% <0.00%> (ø)
src/compute/sort/row/variable.rs 100.00% <0.00%> (ø)
src/compute/comparison/primitive.rs 95.04% <0.00%> (+0.03%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I have a minor comment, but otherwise we can merge it.

src/array/list/mod.rs Outdated Show resolved Hide resolved
@jondo2010 jondo2010 force-pushed the fix_nested_extension_types_head branch 2 times, most recently from 8d5528c to 8e91b9c Compare December 19, 2022 16:15
@jondo2010 jondo2010 force-pushed the fix_nested_extension_types_head branch from 8e91b9c to b4e1de3 Compare December 20, 2022 14:53
@jondo2010
Copy link
Contributor Author

Seems like a codecov submission failure. @jorgecarleitao, can you re-trigger the build on this please?

@jorgecarleitao jorgecarleitao merged commit 133b933 into jorgecarleitao:main Dec 23, 2022
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
Various fixes for nested Extension types
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Various fixes for nested Extension types
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants