Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] administrator/language com_finder #894

Merged
merged 7 commits into from
Feb 12, 2020
Merged

[4.0] administrator/language com_finder #894

merged 7 commits into from
Feb 12, 2020

Conversation

tecpromotion
Copy link
Member

Pull Request für Issue #804 .

Zusammenfassung der Änderungen

rename and 4.0 changes

@tecpromotion tecpromotion added this to the 4.0.0v1 milestone Feb 7, 2020
@tecpromotion tecpromotion requested a review from a team February 7, 2020 08:16
@tecpromotion tecpromotion self-assigned this Feb 7, 2020
@zero-24
Copy link
Member

zero-24 commented Feb 8, 2020

WIP Means there is something still open? Or did you already checked for the changes so we just have to rename it?

@tecpromotion
Copy link
Member Author

WIP Means there is something still open? Or did you already checked for the changes so we just have to rename it?

Have a local stash and some strings are not ready. Will change it later for review.

@tecpromotion tecpromotion changed the title [WIP] [4.0] administrator/language com_finder [4.0] administrator/language com_finder Feb 8, 2020
@tecpromotion
Copy link
Member Author

@zero-24 your turn 🚀

zero-24
zero-24 approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tecpromotion and others added 2 commits February 12, 2020 20:31
@zero-24 zero-24 merged commit d23a6d8 into joomlagerman:4.0-dev Feb 12, 2020
@zero-24 zero-24 deleted the 804-com-finder branch February 12, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zero-24 zero-24 Awaiting requested review from zero-24

Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 4.x
Milestone
4.0.0v1
Development

Successfully merging this pull request may close these issues.
2 participants
@tecpromotion @zero-24