Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] media action fields and a non correct header #839

Merged
merged 15 commits into from
Dec 18, 2019

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Dec 18, 2019

Pull Request für Issue #807

Zusammenfassung der Änderungen

plg_media-action_crop.ini
plg_media-action_crop.sys.ini
plg_media-action_resize.ini
plg_media-action_resize.sys.ini
plg_media-action_rotate.ini
plg_media-action_rotate.sys.ini

This also is fixing an issue with the header of the namespace map files.

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

@zero-24 zero-24 added this to the 4.0.0v1 milestone Dec 18, 2019
@zero-24 zero-24 requested a review from a team December 18, 2019 18:20
@tecpromotion tecpromotion self-assigned this Dec 18, 2019
; Note : All ini files need to be saved as UTF-8

PLG_MEDIA-ACTION_RESIZE="Medienfunktion - Größe ändern"
PLG_MEDIA-ACTION_RESIZE_XML_DESCRIPTION="Fügt eine Größe ändern für Bilder hinzu."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kein Deutsch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PLG_MEDIA-ACTION_RESIZE_XML_DESCRIPTION="Fügt eine Größe ändern für Bilder hinzu."
PLG_MEDIA-ACTION_RESIZE_XML_DESCRIPTION="Fügt eine Größe ändern“-Funktion für Bilder hinzu."

?

Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments @zero-24

tecpromotion and others added 6 commits December 18, 2019 19:35
Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
für den Start

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>
Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tecpromotion tecpromotion merged commit 48da101 into joomlagerman:4.0-dev Dec 18, 2019
@zero-24 zero-24 deleted the 807_media-action branch December 18, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants