Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add new api auth plugin #827

Merged
merged 10 commits into from
Dec 17, 2019
Merged

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Dec 17, 2019

Pull Request für Issue #807

Zusammenfassung der Änderungen

plg_api-authentication_basic.ini
plg_api-authentication_basic.sys.ini
plg_api-authentication_token.ini
plg_api-authentication_token.sys.ini

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

Notice there will be on more plugin please wait on merging for this PR here: joomla/joomla-cms#27021

@zero-24 zero-24 added this to the 4.0.0v1 milestone Dec 17, 2019
@zero-24 zero-24 requested a review from a team December 17, 2019 17:07
; License GNU General Public License version 2 or later; see LICENSE.txt
; Note : All ini files need to be saved as UTF-8

PLG_API-AUTHENTICATION_TOKEN="API Authentifizierung -Joomla Token"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PLG_API-AUTHENTICATION_TOKEN="API Authentifizierung -Joomla Token"
PLG_API-AUTHENTICATION_TOKEN="API Authentifizierung - Joomla Token"

Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
@zero-24
Copy link
Member Author

zero-24 commented Dec 17, 2019

see my comments

wie gesagt ich würde sagen bei diesem speziellen plugin ist für richtig.

Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zero-24

@tecpromotion tecpromotion changed the title [WIP][4.0] Add new api auth plugin [4.0] Add new api auth plugin Dec 17, 2019
@tecpromotion tecpromotion merged commit b0bc2a7 into joomlagerman:4.0-dev Dec 17, 2019
@zero-24 zero-24 deleted the 807_api_auth branch December 17, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants