[5.x] Template color scheme configuration #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero-24
reviewed
Mar 22, 2024
| MOD_USER_EDIT_ACCOUNT="Konto bearbeiten" | ||
| MOD_USER_LIGHT_MODE="Light Mode" |
There was a problem hiding this comment.
Oben haben wir "Helles Farbschema" genommen. Ich bin mir aber nicht sicher
There was a problem hiding this comment.
Wir unterscheiden aber noch mal zwischen Mode und Scheme.
There was a problem hiding this comment.
@zero-24 lass mal mit Light und Dark starten und schauen, was als Feedback kommt.
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
zero-24
reviewed
Mar 22, 2024
zero-24
reviewed
Mar 22, 2024
Ok dann lass uns so gehen. Das "verwenden" sollten wir aber einheitlich nutzen, die anderen stellen waren mir nicht aufgefallen beim ersten mal. ggfs können wir aber auch "verwenden" ganz weglassen? |
zero-24
approved these changes
Mar 22, 2024
|
Merging thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request für Issue #3129 .
Zusammenfassung der Änderungen
Add new strings
translation
Ich habe bewußt "Dark Mode" und "Light Mode" nicht übersetzt. Das sind gesetzte Begriffe und ich würde das gerne so lassen.
Wo wird der Sprachstring angezeigt / Wie kann getestet werden
backend
frontend