Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] quotation marks not speech marks #2726

Merged
merged 7 commits into from
Jan 23, 2023
Merged

[4.2] quotation marks not speech marks #2726

merged 7 commits into from
Jan 23, 2023

Conversation

tecpromotion
Copy link
Member

Pull Request für Issue #2721 .

Zusammenfassung der Änderungen

fix strings

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

Backend

@tecpromotion tecpromotion requested a review from a team January 21, 2023 08:58
@tecpromotion tecpromotion self-assigned this Jan 21, 2023
@tecpromotion tecpromotion added this to the 4.2.7v1 milestone Jan 21, 2023
@tecpromotion tecpromotion linked an issue Jan 21, 2023 that may be closed by this pull request
[4.2] quotation marks not speech marks #2721
Closed
@zero-24
Copy link
Member

zero-24 commented Jan 21, 2023

hatten wir in der Vergangenheit nicht bewusst auf single quotes umgestellt um dem escaping zu entgehen?

@tecpromotion
Copy link
Member Author

Korrekt. Ich passe den PR an. Die eine Satzkorrektur macht schon Sinn.

@zero-24 zero-24 merged commit 3473540 into joomlagerman:4.2-dev Jan 23, 2023
@zero-24 zero-24 deleted the issue-2721 branch January 23, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max123kl max123kl max123kl left review comments

@zero-24 zero-24 zero-24 left review comments

Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 4.x
Milestone
4.2.7v1
Development

Successfully merging this pull request may close these issues.

[4.2] quotation marks not speech marks
3 participants
@tecpromotion @zero-24 @max123kl