Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] re apply 4.3-dev #2691 #2694

Merged
merged 6 commits into from
Dec 19, 2022
Merged

[4.3] re apply 4.3-dev #2691 #2694

merged 6 commits into from
Dec 19, 2022

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Dec 18, 2022

re apply the changes from #2691 (comment)

@zero-24 zero-24 added this to the 4.3.0v1 milestone Dec 18, 2022
@zero-24 zero-24 mentioned this pull request Dec 18, 2022
Merged
@zero-24
Copy link
Member Author

zero-24 commented Dec 18, 2022

Fixed thanks @heelc29

@heelc29
Copy link
Member

heelc29 commented Dec 18, 2022

Is it possible that this PR #2616 is missing?

@zero-24
Copy link
Member Author

zero-24 commented Dec 18, 2022

Yes applied via a71fbdc

tecpromotion
tecpromotion previously approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zero-24
@heelc29 ready to merge?

heelc29
heelc29 previously approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tecpromotion @heelc29
Update administrator/language/de-DE/com_workflow.ini
395e5f4 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@tecpromotion tecpromotion dismissed stale reviews from heelc29 and themself via 395e5f4 December 19, 2022 09:54
@tecpromotion tecpromotion merged commit 5f9aa84 into joomlagerman:4.3-dev Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heelc29 heelc29 heelc29 left review comments

@tecpromotion tecpromotion tecpromotion approved these changes

Assignees

@zero-24 zero-24

Labels
None yet
Milestone
4.3.0v1
Development

Successfully merging this pull request may close these issues.
3 participants
@zero-24 @heelc29 @tecpromotion