Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] Menu item custom field – Revert #2559

Merged
merged 2 commits into from
Aug 18, 2022
Merged

[4.2] Menu item custom field – Revert #2559

merged 2 commits into from
Aug 18, 2022

Conversation

heelc29
Copy link
Member

@heelc29 heelc29 commented Aug 16, 2022

Pull Request für Issue #2558 .

Zusammenfassung der Änderungen

delete files

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

code review

@heelc29 heelc29 self-assigned this Aug 16, 2022
@heelc29 heelc29 linked an issue Aug 16, 2022 that may be closed by this pull request
[4.2] Menu item custom field – Revert #2558
Closed
@heelc29 heelc29 requested a review from a team August 16, 2022 18:46
@tecpromotion tecpromotion added this to the 4.2.1v1 milestone Aug 16, 2022
tecpromotion
tecpromotion previously approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @heelc29

@tecpromotion
Copy link
Member

@joomlagerman/maintainers should we add the two files to the delete part?
https://github.com/joomlagerman/joomla/blob/4.2-dev/script.php

@zero-24
Copy link
Member

zero-24 commented Aug 18, 2022

schaut gut aus danke.

@zero-24 zero-24 merged commit 0fe6586 into joomlagerman:4.2-dev Aug 18, 2022
@heelc29 heelc29 deleted the issue-2558 branch August 18, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zero-24 zero-24 zero-24 approved these changes

@tecpromotion tecpromotion tecpromotion left review comments

Assignees

@heelc29 heelc29

Labels
core language change Joomla! 4.x
Milestone
4.2.1v1
Development

Successfully merging this pull request may close these issues.

[4.2] Menu item custom field – Revert
3 participants
@heelc29 @tecpromotion @zero-24