Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] user profile dob field #2500

Merged
merged 2 commits into from
Jun 17, 2022
Merged

[4.2] user profile dob field #2500

merged 2 commits into from
Jun 17, 2022

Conversation

tecpromotion
Copy link
Member

Pull Request für Issue #2496 .

Zusammenfassung der Änderungen

add two new strings
translation

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

backend

@tecpromotion tecpromotion requested a review from a team June 17, 2022 10:42
@tecpromotion tecpromotion self-assigned this Jun 17, 2022
@tecpromotion tecpromotion added this to the 4.2.0v1 milestone Jun 17, 2022
@tecpromotion tecpromotion linked an issue Jun 17, 2022 that may be closed by this pull request
[4.2] user profile dob field #2496
Closed
zero-24
zero-24 reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move the comments above the lines?

@tecpromotion
Copy link
Member Author

can we move the comments above the lines?

why?

@heelc29
Copy link
Member

heelc29 commented Jun 17, 2022

I think for crowdin it is necessary at the end of the line (joomla/joomla-cms#34671)

Basically comments are moved to the end of the line in the *.ini

image

heelc29
heelc29 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tecpromotion tecpromotion merged commit 936e42a into joomlagerman:4.2-dev Jun 17, 2022
@tecpromotion tecpromotion deleted the issue-2496-1 branch September 26, 2022 18:11
heelc29 added a commit to heelc29/joomla that referenced this pull request Mar 25, 2024
@heelc29
remove string
837c010 
joomlagerman#2500
@heelc29 heelc29 mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zero-24 zero-24 zero-24 left review comments

@heelc29 heelc29 heelc29 approved these changes

Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 4.x
Milestone
4.2.0v1
Development

Successfully merging this pull request may close these issues.

[4.2] user profile dob field
3 participants
@tecpromotion @heelc29 @zero-24