Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Translate lib_joomla #1260

Merged
merged 23 commits into from
Oct 2, 2020
Merged

[4.0] Translate lib_joomla #1260

merged 23 commits into from
Oct 2, 2020

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Oct 2, 2020

Pull Request für Issue #808

Zusammenfassung der Änderungen

Sync lib_joomla.ini for 4.x

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

@zero-24 zero-24 added this to the 4.0.0v1 milestone Oct 2, 2020
@zero-24 zero-24 requested a review from a team October 2, 2020 08:22
This was referenced Oct 2, 2020
Closed
Closed
@zero-24 @tecpromotion
Update administrator/language/de-DE/lib_joomla.ini
f34882c 
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
@zero-24 @tecpromotion
Update administrator/language/de-DE/lib_joomla.ini
558ee49 
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
@zero-24 @tecpromotion
Update administrator/language/de-DE/lib_joomla.ini
ab1f2c5 
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
@zero-24 @tecpromotion
Update administrator/language/de-DE/lib_joomla.ini
603d2d3 
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
tecpromotion
tecpromotion requested changes Oct 2, 2020
View reviewed changes
Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some punctuations. fine?

@zero-24 @tecpromotion
Apply suggestions from code review
cc2cbd3 
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
This was linked to issues Oct 2, 2020
[4.0] Language generally #795
Closed
[4.0] administrator/language generally #808
Closed
This was unlinked from issues Oct 2, 2020
[4.0] Language generally #795
Closed
[4.0] administrator/language generally #808
Closed
@tecpromotion tecpromotion self-requested a review October 2, 2020 08:59
tecpromotion
tecpromotion requested changes Oct 2, 2020
View reviewed changes
Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joomla! :)

@tecpromotion
Copy link
Member

@zero-24 Please check last suggestions and i will merge of course. Thanks a lot!

@zero-24 @tecpromotion
Apply suggestions from code review
b8e7d39 
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
@zero-24
Copy link
Member Author

zero-24 commented Oct 2, 2020

Done.

tecpromotion
tecpromotion approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zero-24

@tecpromotion tecpromotion merged commit 6e82462 into joomlagerman:4.0-dev Oct 2, 2020
@zero-24
Copy link
Member Author

zero-24 commented Oct 2, 2020

Thanks.

@zero-24 zero-24 deleted the 808_libjoomla branch October 2, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecpromotion tecpromotion tecpromotion approved these changes

Assignees

@zero-24 zero-24

Labels
core language change Joomla! 4.x
Milestone
4.0.0v1
Development

Successfully merging this pull request may close these issues.
2 participants
@zero-24 @tecpromotion