Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Uninstall child of package #3079

Closed
jgerman-bot opened this issue Jan 8, 2024 · 0 comments · Fixed by #3080
Closed

[5.1] Uninstall child of package #3079

jgerman-bot opened this issue Jan 8, 2024 · 0 comments · Fixed by #3080

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#42607 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/lib_joomla.ini b/administrator/language/en-GB/lib_joomla.ini
index c935ca774a6a..3be382853420 100644
--- a/administrator/language/en-GB/lib_joomla.ini
+++ b/administrator/language/en-GB/lib_joomla.ini
@@ -545,7 +545,7 @@ JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s
 JLIB_INSTALLER_DEFAULT_STYLE="%s - Default"
 JLIB_INSTALLER_DISCOVER="Discover"
 JLIB_INSTALLER_DISCOVER_INSTALL="Discover Install"
-JLIB_INSTALLER_ERROR_CANNOT_UNINSTALL_CHILD_OF_PACKAGE="The %s extension is part of a package which does not allow individual extensions to be uninstalled."
+JLIB_INSTALLER_ERROR_CANNOT_UNINSTALL_CHILD_OF_PACKAGE="The %1$s extension is part of a <a href='index.php?option=com_installer&view=manage&filter[type]=package&filter[search]=id:%2$s'>package</a> which does not allow individual extensions to be uninstalled."
 JLIB_INSTALLER_ERROR_COMP_DISCOVER_STORE_DETAILS="Component Discover install: Failed to store component details."
 JLIB_INSTALLER_ERROR_COMP_INSTALL_ADMIN_ELEMENT="Component Install: The XML file did not have an administration element."
 JLIB_INSTALLER_ERROR_COMP_INSTALL_DIR_ADMIN="Component Install: Another component is already using folder: %s"
diff --git a/language/en-GB/lib_joomla.ini b/language/en-GB/lib_joomla.ini
index e31571e9b846..560095fe6e08 100644
--- a/language/en-GB/lib_joomla.ini
+++ b/language/en-GB/lib_joomla.ini
@@ -539,7 +539,7 @@ JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s
 JLIB_INSTALLER_DEFAULT_STYLE="%s - Default"
 JLIB_INSTALLER_DISCOVER="Discover"
 JLIB_INSTALLER_DISCOVER_INSTALL="Discover Install"
-JLIB_INSTALLER_ERROR_CANNOT_UNINSTALL_CHILD_OF_PACKAGE="The %s extension is part of a package which does not allow individual extensions to be uninstalled."
+JLIB_INSTALLER_ERROR_CANNOT_UNINSTALL_CHILD_OF_PACKAGE="The %1$s extension is part of a <a href='index.php?option=com_installer&view=manage&filter[type]=package&filter[search]=id:%2$s'>package</a> which does not allow individual extensions to be uninstalled."
 JLIB_INSTALLER_ERROR_COMP_DISCOVER_STORE_DETAILS="Component Discover install: Failed to store component details."
 JLIB_INSTALLER_ERROR_COMP_INSTALL_ADMIN_ELEMENT="Component Install: The XML file did not have an administration element."
 JLIB_INSTALLER_ERROR_COMP_INSTALL_DIR_ADMIN="Component Install: Another component is already using folder: %s"
diff --git a/libraries/src/Installer/InstallerAdapter.php b/libraries/src/Installer/InstallerAdapter.php
index 7154e50db115..49b934e878ac 100644
--- a/libraries/src/Installer/InstallerAdapter.php
+++ b/libraries/src/Installer/InstallerAdapter.php
@@ -1143,7 +1143,7 @@ public function uninstall($id)
          */
         if ($this->extension->package_id && !$this->parent->isPackageUninstall() && !$this->canUninstallPackageChild($this->extension->package_id)) {
             Log::add(
-                Text::sprintf('JLIB_INSTALLER_ERROR_CANNOT_UNINSTALL_CHILD_OF_PACKAGE', $this->extension->name),
+                Text::sprintf('JLIB_INSTALLER_ERROR_CANNOT_UNINSTALL_CHILD_OF_PACKAGE', $this->extension->name, $this->extension->package_id),
                 Log::WARNING,
                 'jerror'
             );
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Jan 8, 2024
@tecpromotion tecpromotion linked a pull request Jan 8, 2024 that will close this issue
zero-24 pushed a commit that referenced this issue Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants