Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] [Guided Tours] Add context to core tours #2935

Closed
heelc29 opened this issue Sep 3, 2023 · 0 comments · Fixed by #2936
Closed

[5.0] [Guided Tours] Add context to core tours #2935

heelc29 opened this issue Sep 3, 2023 · 0 comments · Fixed by #2936
Assignees
@tecpromotion
Labels
core language change Joomla! 5.x

Comments

@heelc29
Copy link
Member

heelc29 commented Sep 3, 2023

joomla/joomla-cms#41303

Click to expand the diff! 
diff --git a/administrator/language/en-GB/mod_guidedtours.ini b/administrator/language/en-GB/mod_guidedtours.ini
index 938898b00fd55..3cd1084db55d2 100644
--- a/administrator/language/en-GB/mod_guidedtours.ini
+++ b/administrator/language/en-GB/mod_guidedtours.ini
@@ -4,9 +4,10 @@
 ; Note : All ini files need to be saved as UTF-8
 
 MOD_GUIDEDTOURS="Guided Tours"
+MOD_GUIDEDTOURS_FIELD_CONTEXT_TOUR_COUNT_DESC="The maximum number of tours to show in the dropdown when related to a page."
+MOD_GUIDEDTOURS_FIELD_CONTEXT_TOUR_COUNT_LABEL="Contextual Tour Count"
 MOD_GUIDEDTOURS_FIELD_TOUR_COUNT_DESC="The maximum number of tours to show in the dropdown."
 MOD_GUIDEDTOURS_FIELD_TOUR_COUNT_LABEL="Tour Count"
-MOD_GUIDEDTOURS_GENERIC_TOUR="Generic"
 MOD_GUIDEDTOURS_MENU="Take a Tour"
 MOD_GUIDEDTOURS_SHOW_ALL="Show all tours"
 MOD_GUIDEDTOURS_START_TOUR="Start Tour"
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Sep 3, 2023
@tecpromotion
fix joomlagerman#2935
bd1d9f4 
translation
@tecpromotion tecpromotion mentioned this issue Sep 3, 2023
Merged
@tecpromotion tecpromotion linked a pull request Sep 3, 2023 that will close this issue
[5.0] [Guided Tours] Add context to core tours #2936
Merged
heelc29 added a commit that referenced this issue Sep 3, 2023
@tecpromotion @heelc29
[5.0] [Guided Tours] Add context to core tours (#2936)
8f4757c 
* add two new strings, remove one

* fix #2935

---------

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@heelc29 heelc29 closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 5.x
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5.0] [Guided Tours] Add context to core tours tecpromotion/joomla
3 participants
@tecpromotion @zero-24 @heelc29