Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Remove unused com_media field "upload_mime_illegal" #2705

Closed
jgerman-bot opened this issue Jan 13, 2023 · 0 comments · Fixed by #2707
Closed

[4.3] Remove unused com_media field "upload_mime_illegal" #2705

jgerman-bot opened this issue Jan 13, 2023 · 0 comments · Fixed by #2707

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#39453 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/components/com_media/config.xml b/administrator/components/com_media/config.xml
index bd43e97d52b0..1fa279907b1e 100644
--- a/administrator/components/com_media/config.xml
+++ b/administrator/components/com_media/config.xml
@@ -119,15 +119,6 @@
 			default="image/jpeg,image/gif,image/png,image/bmp,image/webp,audio/ogg,audio/mpeg,audio/mp4,video/mp4,video/mpeg,video/quicktime,video/webm,application/msword,application/excel,application/pdf,application/powerpoint,text/plain,application/x-zip"
 			showon="restrict_uploads:1"
 		/>
-
-		<field
-			name="upload_mime_illegal"
-			type="text"
-			label="COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_LABEL"
-			description="COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_DESC"
-			default="text/html"
-			showon="restrict_uploads:1"
-		/>
 	</fieldset>
 
 	<fieldset
diff --git a/administrator/language/en-GB/com_media.ini b/administrator/language/en-GB/com_media.ini
index 64c886f030a0..0b3cb6cbd7a9 100644
--- a/administrator/language/en-GB/com_media.ini
+++ b/administrator/language/en-GB/com_media.ini
@@ -42,7 +42,9 @@ COM_MEDIA_FIELD_CHECK_MIME_DESC="Use MIME Magic or Fileinfo to attempt to verify
 COM_MEDIA_FIELD_CHECK_MIME_LABEL="Check MIME Types"
 COM_MEDIA_FIELD_IGNORED_EXTENSIONS_DESC="Ignored file extensions for MIME type checking and restricted uploads."
 COM_MEDIA_FIELD_IGNORED_EXTENSIONS_LABEL="Ignored Extensions"
+; Deprecated, will be removed with 5.0
 COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_DESC="A comma separated list of forbidden MIME types to upload."
+; Deprecated, will be removed with 5.0
 COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_LABEL="Forbidden MIME Types"
 COM_MEDIA_FIELD_LEGAL_AUDIO_EXTENSIONS_DESC="Audio extensions (file types) you are allowed to upload (comma separated). These are used to check for valid audio headers."
 COM_MEDIA_FIELD_LEGAL_AUDIO_EXTENSIONS_LABEL="Legal Audio Extensions (File Types)"
@tecpromotion tecpromotion changed the title [4] Remove unused com_media field "upload_mime_illegal" [4.3] Remove unused com_media field "upload_mime_illegal" Jan 13, 2023
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants