-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module edit backend get slow with a lot of menu items #9516 #9689
Conversation
can confirm on postgresql side exaplain is quite the same should be only a mysql boost
I have tested this item ✅ successfully on 77abb6d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9689. |
Thanks I will test in the morning with the large dataset This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9689. |
I have tested this item ✅ successfully on 77abb6d BeforeTime: 8506.36 ms / 8620.83 ms Memory: 8.762 MB / 13.74 MB Application: afterRenderComponent com_modules AfterTime: 673.98 ms / 780.86 ms Memory: 8.760 MB / 13.75 MB Application: afterRenderComponent com_modules WOW!!!!!This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9689. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9689. |
it still slow but if i cancel the multilang query it work good in the template manager. line 165: is the lang query necessary? i found another problem that in the module manager in menu assignment if i choose thanks in advance |
About the broken tree display
so maybe posting this here is not relevant ? Does it occur with the original SQL query (without changes of this pull request) ? |
Do you imply that this is related to this PR ? - yes i did (i reported the bug) |
@benshaty @benshaty , @alikon , @brianteeman Put it in comments (the language JOIN)
and replace it with an extra query on the languages table that
Find lines:
Replace them with:
|
@benshaty "template manager" ???? can you put a screenshoot ? |
Instead of getting 2-10 rows from the languages table,
and how many rows are created before sorting and filtering occurs ?
Anyway the join with the language tables does so much unneeded data replication
|
so is not a core issue as you are using a non core template |
@alikon the problem is not in the template but the module manager |
why would did it ever fix the broken display ? ))
Now about the delay on form save,
|
let me disagree , is your template code that execute the query 3 times |
@alikon now the template is working good but the order of the modules are defective |
Pull Request for Issue #9516 .
Summary of Changes
query clean (distinct instead of group by)
Testing Instructions
edit a module item from backend with debug plugin enabled and look for
apply the patch and edit a module