[5.3] Refactoring views to directly call models (com_guidedtours to com_newsfeeds) #44164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeutz
approved these changes
Sep 30, 2024
HLeithner
reviewed
Oct 1, 2024
Comment on lines
75
to
90
| /** @var InstallerModel $model */ | ||
| $model = $this->getModel(); | ||
|
|
||
| // Get data from the model. | ||
| $state = $this->get('State'); | ||
| $this->state = $state = $model->getState(); | ||
|
|
||
| // Are there messages to display? | ||
| $showMessage = false; | ||
| $this->showMessage = false; | ||
|
|
||
| if (\is_object($state)) { | ||
| $message1 = $state->get('message'); | ||
| $message2 = $state->get('extension_message'); | ||
| $showMessage = ($message1 || $message2); | ||
| $message1 = $state->get('message'); | ||
| $message2 = $state->get('extension_message'); | ||
| $this->showMessage = ($message1 || $message2); | ||
| } | ||
|
|
||
| $this->showMessage = $showMessage; | ||
| $this->state = &$state; | ||
|
|
||
| $this->addToolbar(); |
There was a problem hiding this comment.
That change looks a bit strange, can we always expect that the state is a Registry or Object?
If not the reference in line 87 may have a special purpose?
There was a problem hiding this comment.
Yes, it always is a Registry object, however you are right, the $state in line 79 is wrong. Fixing it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR refactors the views to get the model object and then directly call the methods of the model instead of going through the
View::get()indirection. This refactors the views of the backend components from com_guidedtours to com_newsfeeds.Testing Instructions
Everything should work the same.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed