[5.1] Add update channel reset to Joomla Update Component #43717

richard67 · 2024-06-28T10:46:06Z

Pull Request for Issue #43591 .

Summary of Changes

This pull request (PR) adds a function to the Joomla Update Component to automatically reset the update source (update channel) to "Default" in the component's options at the end of each CMS core update when it was set to "Joomla Next" before the update.

The reset is done for both the backend and the CLI core update.

The user is notified about the reset, and it is logged in the Joomla Update log file.

If an error happens with the reset, a warning is shown to the user and logged in the Joomla Update log file, but the update is still considered as successful if that was the only error during the update.

There is one difference between the update in the Administrator and the CLI:

The Administrator uses the updated code AFTER the update, so it does not need to have this PR applied before the update. The reset will happen when necessary with the updated code of the update model.
The CLI uses still the old code so the reset does not happen when updating to 5.1.2 with the CLI, but it will happen with future updates with the CLI when necessary.

The reason for the reset is that with the change to TUF-based updates in 5.1.0, the update channels are handled differently to how it was done before (and still is done with 4.4).

With the old XML update sites we could have a particular update several times in different channels so there was no need to switch back.
With TUF the update site URL is the same for the two update sources „Default“ and „Joomla Next“, and they are mapped to channels with JVERSION . '.x' for the "Default" and JVERSION+1 . '.x' for "Joomla Next".
So when you update e.g. from 5.1 to a 6.0 nightly build, "Default" is mapped to channel "5.x" and "Joomla Next" is mapped to channel "6.x" before the update, but after the update "Default" is mapped to channel "6.x" and "Joomla Next" is mapped to channel "7.x".

And when your update source was "Joomla Next" before the update you can only have come from the previous major version. E.g. when you have updated to 5.1 with "Joomla Next" you for sure came from 4.4, and when you have updated to 6.0 with "Joomla Next" you for sure came from the latest 5.x (currently 5.2. but will be 5.4 at the end of the 5.x cycle).

Therefore we can reset from "Joomla Next" to "Default" after every update, there is no need for additional version checks.

The language string COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_NEXT is changed so it doesn't tell about updates for the current major version, which was wrong since the introduction of the TUF-based updates.

Testing Instructions

Test 1: Administrator Live Update - Successful Reset

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1 without the changes from this PR applied, edit file administrator/components/com_joomlaupdate/src/Model/UpdateModel.php and change line 115 from
$updateURL = 'https://update.joomla.org/cms/';
to
$updateURL = 'https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/pr_list.xml';
so the update site is the one created by Drone for this PR.
Go to the Joomla Update Component's settings and change the update source to "Joomla Next".
If no update is found yet, use the "Check for Updates" button.
Perform the update.
Check the result.
Check the update source in Joomla Update Component's settings.

Test 2: Administrator Upload & Update - Successful Reset

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1 without the changes from this PR applied, go to the Joomla Update Component's settings and change the update source to "Joomla Next".
Update the CMS core by uploading in the Joomla Update Component the patched zip package created by Drone for this PR.
You can download that package here: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/Joomla_5.1.2-rc2-dev+pr.43717-Development-Update_Package.zip
Check the result.
Check the update source in Joomla Update Component's settings.

Test 3: Administrator Live Update - Error on Reset

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1 without the changes from this PR applied, edit file administrator/components/com_joomlaupdate/src/Model/UpdateModel.php and change line 115 from
$updateURL = 'https://update.joomla.org/cms/';
to
$updateURL = 'https://test5.richard-fath.de/pr-43717-test-error_list.xml';
This makes the update site point to a modified update package which provokes a database error at the reset of the update source. Besides that the package is equal to the one created by Drone for this PR.
Go to the Joomla Update Component's settings and change the update source to "Joomla Next".
If no update is found yet, use the "Check for Updates" button.
Perform the update.
Check the result.
Check the update source in Joomla Update Component's settings.

Test 4: Administrator Upload & Update - Error on Reset

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1 without the changes from this PR applied, go to the Joomla Update Component's settings and change the update source to "Joomla Next".
Update the CMS core by uploading in the Joomla Update Component a modified update package which provokes a database error at the reset of the update source.
You can download that package here: https://test5.richard-fath.de/Joomla_5.1.2-rc2-dev+pr.43717-Development-Update_Package_error.zip
Check the result.
Check the update source in Joomla Update Component's settings.

Test 5: Administrator Live Update - No Reset Needed

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1 without the changes from this PR applied, edit file administrator/components/com_joomlaupdate/src/Model/UpdateModel.php and change line 115 from
$updateURL = 'https://update.joomla.org/cms/';
to
$updateURL = 'https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/pr_list.xml';
so the update site is the one created by Drone for this PR.
Go to the Joomla Update Component's settings and change the update source to "Default".
If no update is found yet, use the "Check for Updates" button.
Perform the update.
Check the result.
Check the update source in Joomla Update Component's settings.

Repeat the test but this time change the update source to "Custom URL" in step 2, and use the custom URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/pr_list.xml

The result should be the same.

Test 6: Administrator Upload & Update - No Reset Needed

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1 without the changes from this PR applied, go to the Joomla Update Component's settings and change the update source to "Default".
Update the CMS core by uploading in the Joomla Update Component the patched zip package created by Drone for this PR.
You can download that package here: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/Joomla_5.1.2-rc2-dev+pr.43717-Development-Update_Package.zip
Check the result.
Check the update source in Joomla Update Component's settings.

Repeat the test but this time change the update source to "Custom URL" in step 1, and use the custom URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/pr_list.xml

The result should be the same.

Test 7: CLI - Successful Reset

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1, apply the changes from this PR.
Edit file administrator/components/com_joomlaupdate/src/Model/UpdateModel.php and change line 115 from
$updateURL = 'https://update.joomla.org/cms/';
to
$updateURL = 'https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/pr_list.xml';
so the update site is the one created by Drone for this PR.
If you have applied this PR by using the custom update URL or the patched package created by Drone for this PR, you have to edit file libraries/src/Version.php and change line 69 from
public const EXTRA_VERSION = 'rc2-dev+pr.43717';
to
public const EXTRA_VERSION = 'rc2-dev';
so that an update will be found.
If you have used Patchtester to apply the PR you don't need to do that.
Go to the Joomla Update Component's settings and change the update source to "Joomla Next".
If no update is found yet, use the "Check for Updates" button.
Perform the update using the CLI:
php ./cli/joomla.php core:update`
Check the result.
Check the update source in Joomla Update Component's settings.

Test 8: CLI - Error on Reset

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1, apply the changes from this PR.
Edit file administrator/components/com_joomlaupdate/src/Model/UpdateModel.php and change line 115 from
$updateURL = 'https://update.joomla.org/cms/';
to
$updateURL = 'https://test5.richard-fath.de/pr-43717-test-error_list.xml';
This makes the update site point to a modified update package which provokes a database error at the reset of the update source. Besides that the package is equal to the one created by Drone for this PR.
In the same file, change line 2055 from
->set($db->quoteName('params') . ' = :params')
to
->set($db->quoteName('paramsx') . ' = :params')
This will provoke an SQL error when trying to reset the update source.
If you have applied this PR by using the custom update URL or the patched package created by Drone for this PR, you have to edit file libraries/src/Version.php and change line 69 from
public const EXTRA_VERSION = 'rc2-dev+pr.43717';
to
public const EXTRA_VERSION = 'rc2-dev';
so that an update will be found.
If you have used Patchtester to apply the PR you don't need to do that.
Go to the Joomla Update Component's settings and change the update source to "Joomla Next".
If no update is found yet, use the "Check for Updates" button.
Perform the update using the CLI:
php ./cli/joomla.php core:update
Check the result.
Check the update source in Joomla Update Component's settings.

Test 9: CLI - No Reset Needed

On a current 5.1 nightly build or the current 5.1-dev branch or a 5.1.1, apply the changes from this PR.
Edit file administrator/components/com_joomlaupdate/src/Model/UpdateModel.php and change line 115 from
$updateURL = 'https://update.joomla.org/cms/';
to
$updateURL = 'https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/pr_list.xml';
so the update site is the one created by Drone for this PR.
If you have applied this PR by using the custom update URL or the patched package created by Drone for this PR, you have to edit file libraries/src/Version.php and change line 69 from
public const EXTRA_VERSION = 'rc2-dev+pr.43717';
to
public const EXTRA_VERSION = 'rc2-dev';
so that an update will be found.
If you have used Patchtester to apply the PR you don't need to do that.
Go to the Joomla Update Component's settings and change the update source to "Default".
If no update is found yet, use the "Check for Updates" button.
Perform the update using the CLI:
php ./cli/joomla.php core:update
Check the result.
Check the update source in Joomla Update Component's settings.

Repeat the test but this time change the update source to "Custom URL" in step 4, and use the custom URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/77094/pr_list.xml

The result should be the same.

Test 10: Check information on "Joomla Next" update channel

With the changes from this PR applied, check the text shown about the update channel in the update component.

Actual result BEFORE applying this Pull Request

When you are still on the "Joomla Next" update channel after an update from 4.4 to 5.1, there will not be any update found for the CMS core until 6.0.0-alpha1 will be released, and then only updates to 6.0 releases will be found, so you will miss any further updates for 5.1 until that time has come.

There is no notification about that and no automatic reset after the update.

When being on the "Joomla Next" update source, the information shown about the update channel contains wrong information (see red underlined part):

Expected result AFTER applying this Pull Request

Tests 1 and 2: Administrator - Successful Reset

When having the update source (update channel) set to "Joomla Next" in the Joomla Update Component's options before that update, the update source is rest to "Default" at the end of the update, and a success message is shown about that:

The Joomla Update log administrator/logs/joomla_update.php contains an information log about the reset:

2024-07-06T12:46:46+00:00	INFO 192.168.98.1	update	Deleting removed files and folders.
2024-07-06T12:46:51+00:00	INFO 192.168.98.1	update	The update channel has been reset from "Joomla Next" to "Default".
2024-07-06T12:46:51+00:00	INFO 192.168.98.1	update	Cleaning up after installation.
2024-07-06T12:46:52+00:00	INFO 192.168.98.1	update	Update to version 5.1.2-rc2-dev+pr.43717 is complete.

Tests 3 and 4: Administrator - Error on Reset

When having the update source (update channel) set to "Joomla Next" in the Joomla Update Component's options before that update and an error happens with reset of the update source, e.g. due to a database problem, a warning message is shown at the top, telling the user to manually reset the update source, but if there was no other error the update is still shown as successful:

The Joomla Update log administrator/logs/joomla_update.php contains a warning log about the error details and another one about the failed reset:

2024-07-06T13:09:39+00:00	INFO 192.168.98.1	update	Deleting removed files and folders.
2024-07-06T13:09:46+00:00	WARNING 192.168.98.1	update	An error has occurred while running "resetUpdateSource". Code: 1054. Message: Unknown column 'paramsx' in 'field list'.
2024-07-06T13:09:46+00:00	WARNING 192.168.98.1	update	Failed to reset the update channel from "Joomla Next" to "Default". Please change it in the Joomla Update Component's options so you don't miss future updates.
2024-07-06T13:09:47+00:00	INFO 192.168.98.1	update	Cleaning up after installation.
2024-07-06T13:09:47+00:00	INFO 192.168.98.1	update	Update to version 5.1.2-rc2-dev+pr.43717 is complete.

Tests 5 and 6: Administrator - No Reset Needed

When the update source is not "Joomla Next" so it is "Default" or "Custom URL", the update source is not changed, and the update of the CMS core works as it does without this PR:

The Joomla Update log administrator/logs/joomla_update.php does not show anything about reset of the update source:

2024-07-06T12:49:08+00:00	INFO 192.168.98.1	update	Deleting removed files and folders.
2024-07-06T12:49:13+00:00	INFO 192.168.98.1	update	Cleaning up after installation.
2024-07-06T12:49:13+00:00	INFO 192.168.98.1	update	Update to version 5.1.2-rc2-dev+pr.43717 is complete.

Test 7: CLI - Successful Reset

When having the update source (update channel) set to "Joomla Next" in the Joomla Update Component's options before that update, the update source is rest to "Default" at the end of the update, and a success message is shown about that:

The Joomla Update log administrator/logs/joomla_update.php contains an information log about the reset:

2024-07-06T13:58:54+00:00	INFO -	update	Deleting removed files and folders.
2024-07-06T13:58:55+00:00	INFO -	update	The update channel has been reset from "Joomla Next" to "Default".

Test 8: CLI - Error on Reset

When having the update source (update channel) set to "Joomla Next" in the Joomla Update Component's options before that update and an error happens with reset of the update source, e.g. due to a database problem, a warning message is shown, telling the user to manually reset the update source, but if there was no other error the update is still shown as successful:

The Joomla Update log administrator/logs/joomla_update.php contains a warning log about the error details and another one about the failed reset:

2024-07-06T14:04:42+00:00	INFO -	update	Deleting removed files and folders.
2024-07-06T14:04:43+00:00	WARNING -	update	An error has occurred while running "resetUpdateSource". Code: 1054. Message: Unknown column 'paramsx' in 'field list'.
2024-07-06T14:04:43+00:00	WARNING -	update	Failed to reset the update channel from "Joomla Next" to "Default". Please change it in the Joomla Update Component's options so you don't miss future updates.

Test 9: CLI - No Reset Needed

When the update source is not "Joomla Next" so it is "Default" or "Custom URL", the update source is not changed, and the update of the CMS core works as it does without this PR:

The Joomla Update log administrator/logs/joomla_update.php does not show anything about reset of the update source:

2024-07-06T14:02:59+00:00	INFO -	update	Deleting removed files and folders.

Test 10: Check information on "Joomla Next" update channel

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed

Add installer script to com_joomlaupdate for reset of the core update channel from "next" to "default" when updating the component.

Reset the core update channel from "Next" to "default" at the end of an update.

brianteeman · 2024-06-28T15:58:26Z

If we can offer the updates in the same way as before then do we really need to even update the update component?

richard67 · 2024-06-28T16:02:01Z

If we can offer the updates in the same way as before then do we really need to even update the update component?

@brianteeman Like I wrote in the description:

The reset after each update provided with part 1 of the other PR or with this PR here makes still sense, except if we want to provide updates on both channels in parallel also in the future and not only this one time to fix the issue.

brianteeman · 2024-06-28T16:08:54Z

The reset after each update provided with part 1 of the other PR or with this PR here makes still sense, except if we want to provide updates on both channels in parallel also in the future and not only this one time to fix the issue.

that doesnt answer my question. never mind. i obviously speak a different language to everyone else and cannot express myself

richard67 · 2024-06-28T16:12:04Z

@brianteeman It does answer your question. When updates will always be provided on both channels then this PR is not necessary. But I doubt that will be the case, I think it will be only done this time. Anyway that’s not my decision.

richard67 · 2024-06-28T16:13:38Z

P.S. And as described, this PR here doesn’t include the part from the other PR which requires the extra component update.

brianteeman · 2024-06-28T16:16:12Z

@brianteeman It does answer your question. When updates will always be provided on both channels then this PR is not necessary. But I doubt that will be the case, I think it will be only done this time. Anyway that’s not my decision.

Why not - it has been that way for ages and if it has now been established that it can be done that way again why change. I just dont see the reason for the change.

I am on holiday now so cant check but what happens when you update from the cli

richard67 · 2024-06-28T16:20:51Z

@brianteeman Sorry, you were right, I misunderstood your question first.

Why not - it has been that way for ages and if it has now been established that it can be done that way again why change. I just dont see the reason for the change.

Yes, that would be the best. But it might require some additional work for those who deploy the updates to TUF - I am not involved in that so I don’t know if that is the way to go.

I am on holiday now so cant check but what happens when you update from the cli

I haven’t checked that either so it would be good if someone could check.

brianteeman · 2024-06-30T08:35:31Z

I am having some issues testing this but so far I have observed that the error page is
administrator/index.php?option=com_joomlaupdate&view=joomlaupdate&layout=complete&tmpl=component

This produces a "naked" page

Should the error page url not be
administrator/index.php?option=com_joomlaupdate&view=joomlaupdate&layout=complete

So that you get a fully styled page

richard67 · 2024-06-30T09:06:57Z

@brianteeman That in case of error the component layout is used is nothing new from my PR. It was once introduced by Fedir when he improved error reporting and logging of the update component.

HLeithner · 2024-07-02T12:06:07Z

to test the update with the update server please change the 115 line in
administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
from
$updateURL = 'https://update.joomla.org/cms/';
to
$updateURL = 'https://update.joomla.org/alpha/';

then change the channel in the update component options form stable to next

(with stable and next channel) you should get version 5.1.2 stable offered for version 5.1.0 and 5.1.1

this might only work today till the original update server does an timestamp update and the updater might refuse an outdated / different update information depending on the status of the data cached.

HLeithner · 2024-07-02T12:07:19Z

I have tested this item ✅ successfully on 45e1091

works with tuf alpha update from 5.1.1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43717.}

brianteeman · 2024-07-02T12:28:46Z

I have tested this item 🔴 unsuccessfully on 45e1091

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43717.}

brianteeman · 2024-07-02T12:30:26Z

I set the channel to Next
I edited the file as per @HLeithner instructions
I performed the update.

HLeithner · 2024-07-02T12:32:44Z

which version was the installed one?

brianteeman · 2024-07-02T12:34:03Z

which version was the installed one?

2024-07-02T12:27:13+00:00	INFO 127.0.0.1	update	Test logging
2024-07-02T12:27:13+00:00	INFO 127.0.0.1	update	Update started by user admin (132). Old version is 5.1.2-dev+pr.43717.
2024-07-02T12:27:15+00:00	INFO 127.0.0.1	update	Downloading update file from https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43717/downloads/76941/Joomla_5.1.2-dev+pr.43717-Development-Update_Package.zip.
2024-07-02T12:27:21+00:00	INFO 127.0.0.1	update	File Joomla_5.1.2-dev+pr.43717-Development-Update_Package.zip downloaded.
2024-07-02T12:27:21+00:00	INFO 127.0.0.1	update	Starting installation of new version.
2024-07-02T12:27:39+00:00	INFO 127.0.0.1	update	Finalising installation.
2024-07-02T12:27:39+00:00	INFO 127.0.0.1	update	Start of SQL updates.
2024-07-02T12:27:39+00:00	INFO 127.0.0.1	update	The current database version (schema) is 5.1.1-2024-04-18.
2024-07-02T12:27:39+00:00	INFO 127.0.0.1	update	End of SQL updates.
2024-07-02T12:27:39+00:00	INFO 127.0.0.1	update	Uninstalling extensions
2024-07-02T12:27:39+00:00	INFO 127.0.0.1	update	Deleting removed files and folders.
2024-07-02T12:27:40+00:00	INFO 127.0.0.1	update	Cleaning up after installation.
2024-07-02T12:27:40+00:00	INFO 127.0.0.1	update	Update to version 5.1.2-dev+pr.43717 is complete.

HLeithner · 2024-07-02T12:35:48Z

strange are you sure this wasn't an error message form before?

brianteeman · 2024-07-02T12:37:38Z

I do however ask again that as you have demonstrated that the Joomla Next channel can show the next joomla 5 release why do we need to have this PR to change to the Stable channel AND if production insists that this change must be done then it is incomplete as the language string below will now give incorrect information

COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_NEXT="You are on the "%s" update channel. Through this channel you'll receive notifications for all updates of the current Joomla release (5.x) and you will also be notified when the future major release (6.x) will be available. Before upgrading to 6.x you'll need to assess its compatibility with your environment."

richard67 · 2024-07-06T13:12:25Z

I will provide an update later. Changing to draft meanwhile.

richard67 · 2024-07-06T16:02:39Z

Ready for testing again.

brianteeman · 2024-07-06T16:09:10Z

Without an additional change to COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_NEXT this PR is incomplete

richard67 · 2024-07-06T16:32:53Z

Without an additional change to COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_NEXT this PR is incomplete

@brianteeman Done. Wrong information removed from the language string.

richard67 · 2024-07-06T16:38:23Z

Hmm, in the backend the warning which is shown when the reset fails has the right colour, but it maybe has the wrong icon (check mark).

@brianteeman Should it be something else? Do you know which one?

Update: I just see when there is an other error it uses the same check mark icon, class="icon-check-circle":
https://github.com/joomla/joomla-cms/pull/43717/files#diff-04325b3920b8a824d5085b5e5dd8e85cc8e7e5110355829ca178c417e48b860cR44
... so if that should be fixed it might be something for another PR.

administrator/language/en-GB/com_joomlaupdate.ini

tecpromotion

That sounded very clumsy.
@brianteeman can you please take another look at it.Thank you.

richard67 · 2024-07-07T09:34:32Z

@brianteeman Could you check @tecpromotion 's suggested change on the language string? Would be good to have a native speaker instead of 2 Germans 😄

brianteeman · 2024-07-07T10:07:25Z

@brianteeman Could you check @tecpromotion 's suggested change on the language string? Would be good to have a native speaker instead of 2 Germans 😄

done

richard67 · 2024-07-07T10:07:46Z

Thanks

brianteeman · 2024-07-07T10:09:57Z

The more I look at this the more I see it as the wrong thing to do.

administrator/language/en-GB/com_joomlaupdate.ini

richard67 · 2024-07-07T10:27:54Z

The more I look at this the more I see it as the wrong thing to do.

@brianteeman I understand your point.

To all readers: Personally I would also prefer if things could work like in past before the change to TUF so it would not need this PR at all.

I was asked by other maintainers if I can make a pull request like this one now, and that's what I did. But I'm not the one to decide which way it should go.

brianteeman · 2024-07-07T15:49:51Z

The more I look at this the more I see it as the wrong thing to do.

@brianteeman I understand your point.

To all readers: Personally I would also prefer if things could work like in past before the change to TUF so it would not need this PR at all.

I was asked by other maintainers if I can make a pull request like this one now, and that's what I did. But I'm not the one to decide which way it should go.

Surprised the maintainers didnt also ask the people who forced these changes to also look at fixing it.

richard67 · 2024-07-07T18:36:59Z

Surprised the maintainers didnt also ask the people who forced these changes to also look at fixing it.

@brianteeman Sometimes people are busy with private life or job and don't have enough time when needed, so I stepped in to help.

brianteeman · 2024-07-07T19:10:59Z

I need to write more clearly.

This is a major issue that has a serious impact. There is no urgent need to make a release so better to spend the time to make the correct fix than settle on something we both agree is not an ideal solution.

LadySolveig · 2024-07-07T21:43:22Z

Thank you @richard67 for your work!
For me, additional security through the Next Channel only makes sense if it is a conscious decision that I make as a user before the update and not months before and possibly forgotten again by the next major update. This PR ensures that no permanent workaround of the TUF updates is necessary and provides additional security for the end user.
Improvements are always welcome if they still need to be made.

LadySolveig · 2024-07-07T21:48:13Z

Thank you @richard67 and also for suggestions, review and testing to all involved!

brianteeman · 2024-07-08T05:07:19Z

I have no idea at all what you are referring to when you say security

brianteeman · 2024-07-08T09:57:36Z

Why was this merged without a single successful test

richard67 added 9 commits June 22, 2024 18:06

Add installer script to com_joomlaupdate

5333db2

Add installer script to com_joomlaupdate for reset of the core update channel from "next" to "default" when updating the component.

Reset update channel from "Next" to "default"

0b61678

Reset the core update channel from "Next" to "default" at the end of an update.

Some fixes + add new language strings to sys.ini

8ef128b

More fixes

4850b2f

Add deprecation for installer script

f2b21f8

Move channel reset from model to controller

a6ccb9f

Fixes from PHP cs fixer

84bf58b

Remove unnecessary PHPCS hint

6d4329c

Revert separate component update and installer script

45e1091

joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Jun 28, 2024

richard67 mentioned this pull request Jun 28, 2024

[5.1] Add update channel reset to Joomla Update Component version 5.1.2 #43695

Closed

2 tasks

richard67 added this to the Joomla! 5.1.2 milestone Jun 28, 2024

richard67 marked this pull request as ready for review July 6, 2024 16:02

richard67 mentioned this pull request Jul 6, 2024

5.1.1 update is not found #43591

Closed

Change COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_NEXT

581118c

tecpromotion reviewed Jul 6, 2024

View reviewed changes

administrator/language/en-GB/com_joomlaupdate.ini Show resolved Hide resolved

tecpromotion suggested changes Jul 6, 2024

View reviewed changes

brianteeman reviewed Jul 7, 2024

View reviewed changes

administrator/language/en-GB/com_joomlaupdate.ini Outdated Show resolved Hide resolved

richard67 added 2 commits July 7, 2024 12:44

Add information about 5.x to language string

1eb9bbb

Remove strong tag

c8292c3

LadySolveig merged commit b6f4dfd into joomla:5.1-dev Jul 7, 2024
3 checks passed

richard67 deleted the 5.1-dev-update-channel-reset-to-default-revert-script branch July 7, 2024 22:06

richard67 removed the Release Blocker label Jul 7, 2024

jgerman-bot mentioned this pull request Jul 8, 2024

[5.1] Add update channel reset to Joomla Update Component joomlagerman/joomla#3217

Closed

joomlapl-bot mentioned this pull request Jul 8, 2024

[5.1] Add update channel reset to Joomla Update Component JoomlaPolska/jezyk-J4#534

Closed

[5.1] Add update channel reset to Joomla Update Component #43717

[5.1] Add update channel reset to Joomla Update Component #43717

Conversation

richard67 commented Jun 28, 2024 • edited Loading

Summary of Changes

Testing Instructions

Test 1: Administrator Live Update - Successful Reset

Test 2: Administrator Upload & Update - Successful Reset

Test 3: Administrator Live Update - Error on Reset

Test 4: Administrator Upload & Update - Error on Reset

Test 5: Administrator Live Update - No Reset Needed

Test 6: Administrator Upload & Update - No Reset Needed

Test 7: CLI - Successful Reset

Test 8: CLI - Error on Reset

Test 9: CLI - No Reset Needed

Test 10: Check information on "Joomla Next" update channel

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Tests 1 and 2: Administrator - Successful Reset

Tests 3 and 4: Administrator - Error on Reset

Tests 5 and 6: Administrator - No Reset Needed

Test 7: CLI - Successful Reset

Test 8: CLI - Error on Reset

Test 9: CLI - No Reset Needed

Test 10: Check information on "Joomla Next" update channel

Link to documentations

brianteeman commented Jun 28, 2024

richard67 commented Jun 28, 2024

brianteeman commented Jun 28, 2024

richard67 commented Jun 28, 2024

richard67 commented Jun 28, 2024

brianteeman commented Jun 28, 2024

richard67 commented Jun 28, 2024

brianteeman commented Jun 30, 2024

richard67 commented Jun 30, 2024

HLeithner commented Jul 2, 2024

HLeithner commented Jul 2, 2024

brianteeman commented Jul 2, 2024

brianteeman commented Jul 2, 2024

HLeithner commented Jul 2, 2024

brianteeman commented Jul 2, 2024

HLeithner commented Jul 2, 2024

brianteeman commented Jul 2, 2024

richard67 commented Jul 6, 2024

richard67 commented Jul 6, 2024

brianteeman commented Jul 6, 2024

richard67 commented Jul 6, 2024

richard67 commented Jul 6, 2024 • edited Loading

tecpromotion left a comment

Choose a reason for hiding this comment

richard67 commented Jul 7, 2024

brianteeman commented Jul 7, 2024

richard67 commented Jul 7, 2024

brianteeman commented Jul 7, 2024

richard67 commented Jul 7, 2024 • edited Loading

brianteeman commented Jul 7, 2024

richard67 commented Jul 7, 2024

brianteeman commented Jul 7, 2024

LadySolveig commented Jul 7, 2024

LadySolveig commented Jul 7, 2024

brianteeman commented Jul 8, 2024

brianteeman commented Jul 8, 2024

richard67 commented Jun 28, 2024 •

edited

Loading

richard67 commented Jul 6, 2024 •

edited

Loading

richard67 commented Jul 7, 2024 •

edited

Loading