[cypress] ESM docu update #43702
Merged
[cypress] ESM docu update #43702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch '4.4-dev'
Consider file permissions when writing configuration in system tests …
merge joomla/joomla-cms branch 4.4-dev
After PR joomla#43676 '[4.4] Move the Cypress Tests to ESM' the cypress config file is renamed to `.mjs`. This PR is for updating README and architecture pictures.
Update with Cypress defineConfig() syntax for new ESM
1. Error messages still mention `cypress.config.js`, e.g. on EADDRINUSE, even there is only `cypress.config.mjs` exisiting: ``` Your configFile threw an error from: cypress.config.js ``` This is avoided for `npm run cypress` by explicitly specifying the name `cypress.config.mjs`. 2. As this does not work for `npx cypress`, all given commands are changed to use `npm run cypress`.
joomla-cms-bot
added
NPM Resource Changed
|
I have tested this item ✅ successfully on 45325eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43702. |
|
Thanks! |
muhme
added a commit
to muhme/joomla-cms
that referenced
this pull request
Jul 2, 2024
With the joomla#43702 ESM documentation update, the small problem has arisen that `npx` uses `cypress.config.js` in error messages, although `cypress.config.mjs` is used. This was 'fixed' in using `npm`. Unfortunately, it turned out that: * npx cypress run --spec is not replaceable by: * npm run cypress:run --spec therefore changed back. A short note has been added to the Troubleshooting section. It was also discovered that the environment variable in the `sudo` call was set in the wrong order, which has been corrected.
laoneo
added a commit
that referenced
this pull request
Jul 22, 2024
With the #43702 ESM documentation update, the small problem has arisen that `npx` uses `cypress.config.js` in error messages, although `cypress.config.mjs` is used. This was 'fixed' in using `npm`. Unfortunately, it turned out that: * npx cypress run --spec is not replaceable by: * npm run cypress:run --spec therefore changed back. A short note has been added to the Troubleshooting section. It was also discovered that the environment variable in the `sudo` call was set in the wrong order, which has been corrected. Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is renamed to
cypress.config.mjs. This PR is for updating README, architecture pictures and the Cypress run option inpackage.json.Summary of Changes
cypress.config.mjsandcypress.config.dist.mjsin README and architecture pictures.defineConfig()syntax for new ESM--config-file cypress.config.mjsinpackage.jsonto have the new file name in error messages. As this does not work fornpx cypress, all given commands are changed to usenpm run cypressin README.Testing Instructions
cypress.config.jsandcypress.config.dist.jsare updated.npxcommands are replaces by correctnpm runActual result BEFORE applying this Pull Request
tests/System/README.mdand the used architecture pictures are documentingcypress.config.jsandcypress.config.dist.jsnpxfor running Cypress in the code samplesExpected result AFTER applying this Pull Request
tests/System/README.mdand the used architecture pictures are documentingcypress.config.mjsandcypress.config.dist.mjsnpm runfor running Cypress in the code samplesLink to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Note
There are other places with
cypress.config.jsandcypress.config.dist.jsin the source code, which will be covered in a follow-up PR.