Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw an error on Path::clean() if $metaPath isn't found #43604

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

OctavianC
Copy link
Contributor

Pull Request for Issue #43580 .

Summary of Changes

Path::find() returns false if the location cannot be found and Path::clean() throws an error if a non-string value is supplied - this makes menu item editing impossible for components that have been uninstalled.

Testing Instructions

See issue #43580

Actual result BEFORE applying this Pull Request

You must specify a non-empty path to clean
image

Expected result AFTER applying this Pull Request

Menu item editing page opens correctly
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@sousa9g
Copy link

sousa9g commented Jun 3, 2024

Tested successfully, worked fine for me.

@bcraigie
Copy link

Thank you @OctavianC - I can confirm your change works. :-)

@chmst
Copy link
Contributor

chmst commented Jun 10, 2024

Thanks for testing, @sousa9g and @bcraigie. Could you please go to https://issues.joomla.org/tracker/joomla-cms/43604 and confirm your test with the "Test this" Button? Then the patch can be released.

@wilsonge wilsonge enabled auto-merge (rebase) June 12, 2024 17:43
@wilsonge
Copy link
Contributor

Merging this between the two tests not registered in the tracker and on review

@wilsonge wilsonge added this to the Joomla! 5.1.2 milestone Jun 12, 2024
@bcraigie
Copy link

I have tested this item ✅ successfully on 437b42a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43604.

@wilsonge wilsonge merged commit 0356a04 into joomla:5.1-dev Jun 12, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants