Don't throw an error on Path::clean() if $metaPath isn't found #43604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43580 .
Summary of Changes
Path::find() returns false if the location cannot be found and Path::clean() throws an error if a non-string value is supplied - this makes menu item editing impossible for components that have been uninstalled.
Testing Instructions
See issue #43580
Actual result BEFORE applying this Pull Request
You must specify a non-empty path to clean
![image](https://private-user-images.githubusercontent.com/1422378/335956920-4c3bf87c-069f-4373-a634-cd6b0f640076.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNTc4MTgsIm5iZiI6MTcyMzA1NzUxOCwicGF0aCI6Ii8xNDIyMzc4LzMzNTk1NjkyMC00YzNiZjg3Yy0wNjlmLTQzNzMtYTYzNC1jZDZiMGY2NDAwNzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDdUMTkwNTE4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTdlYjUzNzIzNTRkMjUxYzY3ZmZiZjM3OTRkNWI2ZGQwNGZiMjg0ZTM3NjgyMDAxMTI4MjQ3MDUwMTUzN2E5NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.e9bjZexctZJQo9mnOwZ5_iFdU51zFygX2Z56-mdeQ9I)
Expected result AFTER applying this Pull Request
Menu item editing page opens correctly
![image](https://private-user-images.githubusercontent.com/1422378/335956877-bb9a5e55-b77f-4c96-ac8b-b9f6af6d4594.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNTc4MTgsIm5iZiI6MTcyMzA1NzUxOCwicGF0aCI6Ii8xNDIyMzc4LzMzNTk1Njg3Ny1iYjlhNWU1NS1iNzdmLTRjOTYtYWM4Yi1iOWY2YWY2ZDQ1OTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDdUMTkwNTE4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MWVlMjIxMWNlYzZmYmJiYzkyNWE2OGI0NGJiMzVhOGFhMzk1YjA4MDNjZDEwMGQwZjhmMzhhMDc1ZWQ5MDZmMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.vZVoiNq9Uk7ZSfxbpXu5VMQVooLN0BKeDyZR7XdA0hU)
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed