Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Fix missing aria-label in pagenavigation #43600

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jun 2, 2024

Pull Request for Issue # .

Summary of Changes

The <nav in pagenavigation needs an aria-label.

Testing Instructions

You need a site where you have a pageanavigation.
Inspect the sourceode before and after patch

Actual result BEFORE applying this Pull Request

No aria-label for the <nav element

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.4-dev labels Jun 2, 2024
@chmst chmst added the a11y Accessibility label Jun 2, 2024
Co-authored-by: Brian Teeman <brian@teeman.net>
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on aab5d65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43600.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 2, 2024

I have tested this item ✅ successfully on aab5d65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43600.

@Quy
Copy link
Contributor

Quy commented Jun 2, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43600.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 2, 2024
@MacJoom MacJoom self-assigned this Jun 14, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.6 milestone Jun 14, 2024
@MacJoom MacJoom merged commit 6847312 into joomla:4.4-dev Jun 14, 2024
3 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Jun 14, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 14, 2024
@chmst chmst deleted the a11y-pagenavigation-arialabel branch June 14, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility Language Change This is for Translators PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants