Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove myself from the CODEOWNERS file #43482

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented May 16, 2024

Summary of Changes

Remove myself from the CODEOWNERS file.

Testing Instructions

Its just a config file so only a review & merge is needed
Please merge it up to 5.x-dev and 6.x-dev once merged.

@brianteeman
Copy link
Contributor

This change highlights a problem in the file

Unknown owner on line 9: make sure @fancyFranci exists and has write access to the repository
build.xml @fancyFranci

@zero-24
Copy link
Contributor Author

zero-24 commented May 16, 2024

Yes I can include it here when there is no reason that she is still part of that file maybe its intended for documentation reasons?

@laoneo laoneo merged commit 1e84e51 into joomla:4.4-dev May 16, 2024
3 checks passed
@zero-24 zero-24 deleted the codeowner branch May 16, 2024 16:07
@zero-24
Copy link
Contributor Author

zero-24 commented May 16, 2024

Thanks :)

@laoneo
Copy link
Member

laoneo commented May 16, 2024

I'm merging this as the @fancyFranci should be done in a different pr.

Thanks @zero-24 for all the work in these years!

@laoneo laoneo added this to the Joomla! 4.4.5 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants