Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] MFA Backup Codes [a11y] [UI] #43450

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #43449 .

Summary of Changes

  1. Combine nested if
  2. add a class to the link to force it to be underlined

Testing Instructions

Enable any of the MFA methods and then try to print out the backup codes

Actual result BEFORE applying this Pull Request

chrome_3Ns56XJJ8c

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.4-dev labels May 9, 2024
@brianteeman
Copy link
Contributor Author

This is an option. Another would be to change it from a string and link to a button similar to
image

@richard67
Copy link
Member

@brianteeman Does this close the referred issue #43449 ?

@brianteeman
Copy link
Contributor Author

it's an option

@dautrich
Copy link

I have tested this item ✅ successfully on c432910


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

Co-authored-by: Quy <quy@nomonkeybiz.com>
@dautrich
Copy link

I have tested this item ✅ successfully on 559d520


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

@Quy
Copy link
Contributor

Quy commented May 13, 2024

I have tested this item ✅ successfully on 559d520


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

@Quy
Copy link
Contributor

Quy commented May 13, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 13, 2024
@MacJoom MacJoom self-assigned this May 14, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.5 milestone May 14, 2024
@MacJoom MacJoom merged commit 92cad14 into joomla:4.4-dev May 14, 2024
3 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented May 14, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 14, 2024
@brianteeman brianteeman deleted the 4.4-dev-mfa branch May 14, 2024 12:54
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants