Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Backport fix for Error in PrivacyConsent::getPrivacyItemId() #43445

Merged

Conversation

SniperSister
Copy link
Contributor

Summary of Changes

Backport changes from #41976 to 4.x branch

Testing Instructions

See original PR.

Actual result BEFORE applying this Pull Request

See original PR.

Expected result AFTER applying this Pull Request

See original PR.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I have tested this item ✅ successfully on 8d2374f

Tested by code review: The application object doesn't have a getTag method, but the language object has.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43445.

@MacJoom MacJoom self-assigned this May 9, 2024
@Quy
Copy link
Contributor

Quy commented May 15, 2024

I have tested this item ✅ successfully on 8d2374f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43445.

@Quy Quy changed the title [4.x] Backport fix for Error in PrivacyConsent::getPrivacyItemId() [4.x] Backport fix for Error in PrivacyConsent::getPrivacyItemId() May 15, 2024
@Quy
Copy link
Contributor

Quy commented May 15, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43445.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 15, 2024
@Quy Quy added this to the Joomla! 4.4.5 milestone May 15, 2024
@MacJoom MacJoom merged commit 866e6f1 into joomla:4.4-dev May 17, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 17, 2024
@MacJoom
Copy link
Contributor

MacJoom commented May 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants