[5.2] scss comments #43436
Merged
[5.2] scss comments #43436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single line comments should begin with // followed by a space This has zero effect on compiling the css. It is just for - consistency - easier to search for a comment without finding all the urls - some scss documentation tools require the space - pedantic
joomla-cms-bot
added
NPM Resource Changed
Quy
reviewed
May 7, 2024
build/media_source/templates/administrator/atum/scss/vendor/choicesjs/choices.scss
Outdated
Show resolved
Hide resolved
…oicesjs/choices.scss Co-authored-by: Quy <quy@nomonkeybiz.com>
wilsonge
reviewed
May 8, 2024
build/media_source/templates/administrator/atum/scss/_variables.scss
Outdated
Show resolved
Hide resolved
|
LGTM and all whitespace changes now so merging on review. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single line comments should begin with // followed by a space
This has zero effect on compiling the css. It is just for
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed