[4.4] Pin version MySql Version in Tests to 8.0 #43420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
reviewed
May 2, 2024
|
Given the bugfix/LTS version is 8.0 and 8.3 is the 'innovation track' without any LTS surely we just want to be recommending people use the 8.0 series for now and test against that? https://dev.mysql.com/doc/mysql-installation-excerpt/8.3/en/which-version.html At minimum we should test 8.0 and latest 8.x because most hosts will stick on 8.0 for that reason |
@wilsonge Did you mean latest 8.0.x? And what do you suggest for this PR here? Change it to 8.0 for now? |
richard67
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Pinned the mysql version to 8.0
Testing Instructions
Check drone if integration tests are working
Actual result BEFORE applying this Pull Request
integration tests failing
Expected result AFTER applying this Pull Request
integration tests are working