Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Pin Mysql Version to 8.0 #43418

Merged
merged 10 commits into from
May 5, 2024
Merged

Conversation

rdeutz
Copy link
Contributor

@rdeutz rdeutz commented May 2, 2024

Summary of Changes

Allow --mysql-native-password=ON for mysql 8.4.0, the option is disabled by default from 8.4.0

Pinned the mysql version to 8.0

Testing Instructions

Check drone if integration tests are working

Actual result BEFORE applying this Pull Request

integration tests failing

Expected result AFTER applying this Pull Request

integration tests are working

@laoneo
Copy link
Member

laoneo commented May 2, 2024

Following, as I do run into the same issue with DPDocker with MySQL 8.4 where they have disabled the native auth plugin. On my drone instance I switched to mariaDB, but would love to see this fixed with mysql.

@rdeutz rdeutz changed the base branch from 5.2-dev to 5.1-dev May 2, 2024 14:06
@rdeutz rdeutz requested review from laoneo and chmst as code owners May 2, 2024 14:06
@rdeutz rdeutz changed the base branch from 5.1-dev to 5.2-dev May 2, 2024 14:06
@rdeutz rdeutz changed the title [5.2] Allow native passwords for MySQL [5.2] Pin Mysql Version to 8.3. May 2, 2024
@richard67 richard67 changed the title [5.2] Pin Mysql Version to 8.3. [5.2] Pin Mysql Version to 8.0 May 5, 2024
@wilsonge wilsonge merged commit 4c9f2b3 into joomla:5.2-dev May 5, 2024
3 checks passed
@wilsonge wilsonge modified the milestone: Joomla! 5.2.0 May 5, 2024
@wilsonge
Copy link
Contributor

wilsonge commented May 5, 2024

Deliberately not setting a milestone here as it's been merged for 5.1 and 4.4 - but this just allows the merge up to be easier

@rdeutz rdeutz deleted the update-mysql-start branch July 30, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants