Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] TinyMCe insert content #43411

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented May 1, 2024

This changes the button text used when selecting a content template from "Save" to "Insert".

No additional changes are required for this to be translated as "Insert" is already translated.

(This PR was created at the request of "Daniel C K Tan" on facebook.

Testing Instructions

If you dont already have content templates set up and working for tinymce go to the plugin settings for tinymce and setup the correct folder
image

Then create a .txt file in that folder. (As this is just to test the UI the file can be empty)

Finaly in an article select the content template icon from the toolbar
image

And in the dialog that opens observe the text of the buttons.

Then apply this PR and retest. As it is a js change either apply the pr and then run npm i or use the prebuilt joomla package that can be found at the bottom of this page at the download link

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

This changes the button text used when selecting a content template from "Save" to "Insert".

No additional changes are required for this to be translated as "Insert" is already translated.

(This PR was created at the request of "Daniel C K Tan" on facebook.
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels May 1, 2024
@Fedik
Copy link
Member

Fedik commented May 1, 2024

I have tested this item ✅ successfully on 8dd3109


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43411.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 8dd3109


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43411.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43411.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 1, 2024
@pe7er pe7er self-assigned this May 7, 2024
@pe7er pe7er merged commit 05563db into joomla:5.2-dev May 7, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 7, 2024
@pe7er
Copy link
Contributor

pe7er commented May 7, 2024

Thanks @brianteeman !

@brianteeman brianteeman deleted the insert_template branch May 7, 2024 11:38
@Quy Quy added this to the Joomla! 5.2.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants