-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Joomla Update : extensions check never ends (from #43226) #43410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing item name
….php Co-authored-by: Brian Teeman <brian@teeman.net>
….php Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php Co-authored-by: Brian Teeman <brian@teeman.net>
remove tabs
add new lines at end of files
wilsonge
approved these changes
May 1, 2024
4 tasks
Looks good |
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #43226 closed by mistake
Summary of Changes
Fix PHP 8.2 deprecated notices during Extensions check while performing Joomla 5.1.0 update
Testing Instructions
Joomla 5.0.3, PHP 8.2 or higher, enable Error reporting to default.
In Joomla Update configuration, set "Potentially incompatible extensions checkbox" to "Show".
Install any non core extension
Update Joomla to 5.1.0-RC shows the Pre-Update Screen.
Actual result BEFORE applying this Pull Request
Extensions check never ends, an error appears in explorer console : uncaught syntaxError..
Expected result AFTER applying this Pull Request
Extensions check works fine
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed