Fix System test com_privacy consent (#42523) #43400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussion with Alikon the fix is simple 10 milliseconds waiting time after changing sorting order. The five failures were reproducable in 4.4-dev and ifixed and it is expected it works for 5.1 the same way.
|
I have tested this item ✅ successfully on f26ce42 Applied PR Bug gone - Thank YOU!! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43400. |
|
I have tested this item ✅ successfully on f26ce42 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43400. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43400. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with Alikon the fix is simple 10 milliseconds waiting time after changing sorting order. The five failures were reproducable in 4.4-dev and fixed and it is expected it works the same way for 5.1.
Pull Request for Issue #42523.
Summary of Changes
After selecting a new sorting order it is needed to wait for the POST request to be fullfilled.
This is simple possible by waiting 10 milliseconds. 1 millisecond was enough, but to be save,
10 milliseconds are used.
Testing Instructions
In system test environment with Cypress test e.g. headless:
npm run cypress:run -- --spec tests/System/integration/administrator/components/com_privacy/Consent.cy.js
Please consider this is a racing condition. On drone the test were ?always? successful.
Therefore test first the failure, then patch and test success.
Actual result BEFORE applying this Pull Request
5 of the 24 tests in the spec failed.
Expected result AFTER applying this Pull Request
All 24 tests in the spec are successful.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed