Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace at feature in SessionManagerTest unit test #43381

Merged
merged 2 commits into from
May 7, 2024

Conversation

rdeutz
Copy link
Contributor

@rdeutz rdeutz commented Apr 27, 2024

Pull Request for Issue #42528 .

Summary of Changes

Remove the at() function because it is deprecated for phpunit10.

Site note: Can be discussed if the test has make sense in the past, here I only made it run.

Testing Instructions

run the unit test e.g. phpunit --testdox --filter SessionManagerTest

Actual result BEFORE applying this Pull Request

deprecated messages for the test

Expected result AFTER applying this Pull Request

no deprecated messages for the test

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

This does not resolve the reported issue. "phpunit it out of date and unsupported"

@rdeutz
Copy link
Contributor Author

rdeutz commented Apr 27, 2024

I want to do it in two steps, one to fix the test and when this is done update the phpunit version

@brianteeman
Copy link
Contributor

thats perfect and expected but you shoujldnt have closed the issue until both are done

@rdeutz rdeutz requested a review from laoneo April 27, 2024 15:53
@wilsonge wilsonge enabled auto-merge (squash) May 7, 2024 21:37
@wilsonge wilsonge merged commit c1223f0 into joomla:5.2-dev May 7, 2024
3 checks passed
@wilsonge wilsonge added this to the Joomla! 5.2.0 milestone May 7, 2024
@wilsonge
Copy link
Contributor

wilsonge commented May 7, 2024

Thanks!

@rdeutz rdeutz deleted the phpunit-at-fix branch May 14, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants