-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputFilter fails on cleaning string with HEX entities as string #43377
Conversation
I have tested this item ✅ successfully on fee33cb It yields the answer of: string(2) "ÿ" so if that is expected - perfect. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43377. |
I've restored @exlemor 's test result in the issue tracker so it's properly counted again. The commits which have invalidated the count were just clean branch updates.
@exlemor Yes, that character fits to the Unicode character given as hexadecimal number. See e.g. https://www.w3schools.com/charsets/tryit.asp?deci=255&ent=yuml . |
I have tested this item ✅ successfully on 3d3e148 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43377. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43377. |
Thank you! |
Summary of Changes
InputFilter::clean($string, 'string')
fails when decoding the entities with HEX numbersTesting Instructions
Execute the code:
Actual result BEFORE applying this Pull Request
See error
chr(): Argument #1 ($codepoint) must be of type int, string given
Expected result AFTER applying this Pull Request
No errors.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed